mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Ten Gao <gaoyankaigeren@gmail.com>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>,
	Bart Van Assche <bvanassche@acm.org>,
	"James E . J . Bottomley" <jejb@linux.ibm.com>,
	Bean Huo <beanhuo@micron.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Mike Snitzer <snitzer@redhat.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Kiwoong Kim <kwmad.kim@samsung.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ufs: core: remove encrypt when no data transfer
Date: Tue, 11 Oct 2022 09:57:06 -0700	[thread overview]
Message-ID: <Y0WgYlbV4RBqd+lU@sol.localdomain> (raw)
In-Reply-To: <20221011072126.30802-1-gaoyankaigeren@gmail.com>

On Tue, Oct 11, 2022 at 03:21:26PM +0800, Ten Gao wrote:
> From: Ten Gao <ten.gao@unisoc.com>
> 
> when there is no data transmission, ufs is unnecessary to encrypt.
> We need to adjust scsi crypto relation.
> 
> Signed-off-by: Ten Gao <ten.gao@unisoc.com>
> ---
>  drivers/ufs/core/ufshcd-crypto.h | 10 ++++++----
>  include/ufs/ufshci.h             |  2 ++
>  2 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/ufs/core/ufshcd-crypto.h b/drivers/ufs/core/ufshcd-crypto.h
> index 504cc841540b..5bc2a0cbdfa6 100644
> --- a/drivers/ufs/core/ufshcd-crypto.h
> +++ b/drivers/ufs/core/ufshcd-crypto.h
> @@ -30,10 +30,12 @@ ufshcd_prepare_req_desc_hdr_crypto(struct ufshcd_lrb *lrbp, u32 *dword_0,
>  				   u32 *dword_1, u32 *dword_3)
>  {
>  	if (lrbp->crypto_key_slot >= 0) {
> -		*dword_0 |= UTP_REQ_DESC_CRYPTO_ENABLE_CMD;
> -		*dword_0 |= lrbp->crypto_key_slot;
> -		*dword_1 = lower_32_bits(lrbp->data_unit_num);
> -		*dword_3 = upper_32_bits(lrbp->data_unit_num);
> +		if ((*dword_0 & UTRD_DIRECTION) != UTP_NO_DATA_TRANSFER) {
> +			*dword_0 |= UTP_REQ_DESC_CRYPTO_ENABLE_CMD;
> +			*dword_0 |= lrbp->crypto_key_slot;
> +			*dword_1 = lower_32_bits(lrbp->data_unit_num);
> +			*dword_3 = upper_32_bits(lrbp->data_unit_num);
> +		}
>  	}
>  }

This is very dangerous, as it will silently skip en/decryption.  Why was a
keyslot assigned in the first place if the I/O doesn't need en/decryption?

- Eric

      reply	other threads:[~2022-10-11 16:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11  7:21 Ten Gao
2022-10-11 16:57 ` Eric Biggers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y0WgYlbV4RBqd+lU@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=gaoyankaigeren@gmail.com \
    --cc=jejb@linux.ibm.com \
    --cc=kwmad.kim@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=snitzer@redhat.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®