From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 678F3C433FE for ; Wed, 12 Oct 2022 09:29:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229915AbiJLJ3Y (ORCPT ); Wed, 12 Oct 2022 05:29:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229533AbiJLJ3W (ORCPT ); Wed, 12 Oct 2022 05:29:22 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F42326DFA4; Wed, 12 Oct 2022 02:29:20 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1oiY2r-00DtAP-6F; Wed, 12 Oct 2022 20:28:58 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Wed, 12 Oct 2022 17:28:57 +0800 Date: Wed, 12 Oct 2022 17:28:57 +0800 From: Herbert Xu To: Christian Langrock Cc: Steffen Klassert , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH ipsec v6] xfrm: replay: Fix ESN wrap around for GSO Message-ID: References: <6810817b-e6b7-feac-64f8-c83c517ae9a5@secunet.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6810817b-e6b7-feac-64f8-c83c517ae9a5@secunet.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 07, 2022 at 04:50:15PM +0200, Christian Langrock wrote: > When using GSO it can happen that the wrong seq_hi is used for the last > packets before the wrap around. This can lead to double usage of a > sequence number. To avoid this, we should serialize this last GSO > packet. > > Fixes: d7dbefc45cf5 ("xfrm: Add xfrm_replay_overflow functions for offloading") > Co-developed-by: Steffen Klassert > Signed-off-by: Christian Langrock > --- > Changes in v6: > - move overflow check to offloading path to avoid locking issues > > Changes in v5: > - Fix build > > Changes in v4: > - move changelog within comment > - add reviewer > > Changes in v3: > - fix build > - remove wrapper function > > Changes in v2: > - switch to bool as return value > - remove switch case in wrapper function > --- > net/ipv4/esp4_offload.c | 3 +++ > net/ipv6/esp6_offload.c | 3 +++ > net/xfrm/xfrm_device.c | 15 ++++++++++++++- > net/xfrm/xfrm_replay.c | 2 +- > 4 files changed, 21 insertions(+), 2 deletions(-) Could you please explain how this code restructure makes it safe with respect to multiple users of the same xfrm_state? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt