mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jack Rosenthal <jrosenth@chromium.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Julius Werner <jwerner@chromium.org>,
	LKML <linux-kernel@vger.kernel.org>,
	chrome-platform@lists.linux.dev,
	Stephen Boyd <swboyd@chromium.org>,
	Tzung-Bi Shih <tzungbi@kernel.org>,
	Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH v12] firmware: google: Implement cbmem in sysfs driver
Date: Thu, 13 Oct 2022 15:25:58 -0600	[thread overview]
Message-ID: <Y0iCZip0k9WcHgsz@chromium.org> (raw)
In-Reply-To: <Yz52r89A9JYEICCi@kroah.com>

On 2022-10-06 at 08:33 +0200, Greg KH wrote:
> On Wed, Oct 05, 2022 at 04:26:55PM -0700, Julius Werner wrote:
> > > If the kernel is reporting a value, that value needs to be documented
> > > somewhere.  If the kernel is acting on that value, it needs to know what
> > > those values are.
> > >
> > > In this specific instance it seems that the kernel knows a subset of the
> > > values, and some random userspace tool knows all of them?  Think about
> > > what you would want to see here if you knew nothing about this at all.
> > 
> > The kernel doesn't know any of the values. The kernel is just telling
> > userspace that spaces with these IDs exist and providing an interface
> > to access them, it's not supposed to know what any of them mean.
> 
> Ah, ok, that was not obvious to me, sorry.  If the kernel is just a
> pass-through, no objections.

Does this mean PATCH v13 looks good to you?

thanks,

jack

  reply	other threads:[~2022-10-13 21:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-04  0:38 Jack Rosenthal
2022-10-04  8:51 ` Greg KH
2022-10-04 16:56   ` Jack Rosenthal
2022-10-04 17:26     ` Greg KH
2022-10-04 22:56       ` Jack Rosenthal
2022-10-05  1:10         ` Julius Werner
2022-10-05  6:25           ` Greg KH
2022-10-05 23:26             ` Julius Werner
2022-10-06  6:33               ` Greg KH
2022-10-13 21:25                 ` Jack Rosenthal [this message]
2022-10-14  7:24                   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y0iCZip0k9WcHgsz@chromium.org \
    --to=jrosenth@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=groeck@chromium.org \
    --cc=jwerner@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=swboyd@chromium.org \
    --cc=tzungbi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®