From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37DDAC4332F for ; Fri, 14 Oct 2022 07:24:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229833AbiJNHYQ (ORCPT ); Fri, 14 Oct 2022 03:24:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229727AbiJNHYO (ORCPT ); Fri, 14 Oct 2022 03:24:14 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21E7D19C07E for ; Fri, 14 Oct 2022 00:24:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C8FF5B82166 for ; Fri, 14 Oct 2022 07:24:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2BF4C433D6; Fri, 14 Oct 2022 07:24:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665732250; bh=3+4ELQRvpQGXuMkn5AtQjc15E6olmIrVFv8lJeW/QFg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QXpkCrpIJPJWtsWLfgYXVvltQKARrqoxunUliXHr3UDG9hWTFntI4Px6MtP+9FkO0 v0PpDzTczjwnR4yW8TanxlfPBwefeHcpswq8V3ihfTq912Dnt8LMRb22TkRXQHzfp7 yK7oVRvlVkj8srZ/tDa4+EAzktnct7Q9Gf5hNa4I= Date: Fri, 14 Oct 2022 09:24:54 +0200 From: Greg KH To: Jack Rosenthal Cc: Julius Werner , LKML , chrome-platform@lists.linux.dev, Stephen Boyd , Tzung-Bi Shih , Guenter Roeck Subject: Re: [PATCH v12] firmware: google: Implement cbmem in sysfs driver Message-ID: References: <20221004003811.4075765-1-jrosenth@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 13, 2022 at 03:25:58PM -0600, Jack Rosenthal wrote: > On 2022-10-06 at 08:33 +0200, Greg KH wrote: > > On Wed, Oct 05, 2022 at 04:26:55PM -0700, Julius Werner wrote: > > > > If the kernel is reporting a value, that value needs to be documented > > > > somewhere. If the kernel is acting on that value, it needs to know what > > > > those values are. > > > > > > > > In this specific instance it seems that the kernel knows a subset of the > > > > values, and some random userspace tool knows all of them? Think about > > > > what you would want to see here if you knew nothing about this at all. > > > > > > The kernel doesn't know any of the values. The kernel is just telling > > > userspace that spaces with these IDs exist and providing an interface > > > to access them, it's not supposed to know what any of them mean. > > > > Ah, ok, that was not obvious to me, sorry. If the kernel is just a > > pass-through, no objections. > > Does this mean PATCH v13 looks good to you? No idea, sorry. It's the middle of the merge window, as my bot told you, so I can't do anything with changes until after it is over. Please relax, there is no rush here... greg k-h