From: David Vernet <void@manifault.com>
To: bpf@vger.kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org,
linux-kernel@vger.kernel.org, kernel-team@fb.com, tj@kernel.org,
memxor@gmail.com
Subject: Re: [PATCH v3 1/3] bpf: Allow trusted pointers to be passed to KF_TRUSTED_ARGS kfuncs
Date: Fri, 14 Oct 2022 15:19:39 -0500 [thread overview]
Message-ID: <Y0nEW14JcWPqRCMO@maniforge.dhcp.thefacebook.com> (raw)
In-Reply-To: <20221014201427.2435461-2-void@manifault.com>
On Fri, Oct 14, 2022 at 03:14:25PM -0500, David Vernet wrote:
[...]
> @@ -5768,6 +5778,9 @@ static int check_reg_type(struct bpf_verifier_env *env, u32 regno,
> if (arg_type & PTR_MAYBE_NULL)
> type &= ~PTR_MAYBE_NULL;
>
> + if (!(arg_type & ARG_PTR_TO_BTF_ID))
> + type &= ~PTR_NESTED;
> +
Argh, I added while debugging something and I meant to remove it before
sending out the next version. I'll send out v4 shortly without this,
apologies for the noise.
next prev parent reply other threads:[~2022-10-14 20:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 20:14 [PATCH v3 0/3] Support storing struct task_struct objects as kptrs David Vernet
2022-10-14 20:14 ` [PATCH v3 1/3] bpf: Allow trusted pointers to be passed to KF_TRUSTED_ARGS kfuncs David Vernet
2022-10-14 20:19 ` David Vernet [this message]
2022-10-14 20:14 ` [PATCH v3 2/3] bpf: Add kfuncs for storing struct task_struct * as a kptr David Vernet
2022-10-14 20:14 ` [PATCH v3 3/3] bpf/selftests: Add selftests for new task kfuncs David Vernet
2022-10-18 1:53 ` Kumar Kartikeya Dwivedi
2022-10-18 2:03 ` Kumar Kartikeya Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0nEW14JcWPqRCMO@maniforge.dhcp.thefacebook.com \
--to=void@manifault.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel-team@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=tj@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®