From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96C1DC4332F for ; Sat, 15 Oct 2022 17:19:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229660AbiJORTd (ORCPT ); Sat, 15 Oct 2022 13:19:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbiJORTa (ORCPT ); Sat, 15 Oct 2022 13:19:30 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3767F63CD for ; Sat, 15 Oct 2022 10:19:29 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 50097480; Sat, 15 Oct 2022 19:19:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1665854367; bh=BVOOMbpo1cWjq0urB9svsEQu97CcZuMCenTe5Ij8sA4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DyiCDzW028z9H41qVM3cfYeTvLivo1EdVFOGacX1QeUZUAZ/6X5By32pWpMVk5YGi QiLIbgPxKT5l3CEmnVsgoCRWDpnDaOyWTj7ctXW4eye5thMsksVnel+CgbqbSr1aPk wdCobjIJeM3q2OlIqwKpoVChfo845s/fRZOoks+I= Date: Sat, 15 Oct 2022 20:19:03 +0300 From: Laurent Pinchart To: Maxime Ripard Cc: Maxime Ripard , Eric Anholt , Daniel Vetter , David Airlie , Rob Herring , Emma Anholt , dri-devel@lists.freedesktop.org, Joerg Quinten , Chris Morgan , Dave Stevenson , linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] drm/vc4: dpi: Fix format mapping for RGB565 Message-ID: References: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> <20221013-rpi-dpi-improvements-v1-7-8a7a96949cb0@cerno.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221013-rpi-dpi-improvements-v1-7-8a7a96949cb0@cerno.tech> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime and Dave, Thank you for the patch. On Thu, Oct 13, 2022 at 11:56:51AM +0200, Maxime Ripard wrote: > From: Dave Stevenson > > The mapping is incorrect for RGB565_1X16 as it should be > DPI_FORMAT_18BIT_666_RGB_1 instead of DPI_FORMAT_18BIT_666_RGB_3. The driver includes the following macro definitions and comments: /* Outputs 00000000rrrrrggggggbbbbb */ # define DPI_FORMAT_16BIT_565_RGB_1 1 /* Outputs 000rrrrr00gggggg000bbbbb */ # define DPI_FORMAT_16BIT_565_RGB_2 2 /* Outputs 00rrrrr000gggggg00bbbbb0 */ # define DPI_FORMAT_16BIT_565_RGB_3 3 MEDIA_BUS_FMT_RGB565_1X16 is defined as described in https://linuxtv.org/downloads/v4l-dvb-apis/userspace-api/v4l/subdev-formats.html#id3: Bit | 15 14 13 12 11 10 9 8 7 6 5 4 3 2 1 0 Data | r4 r3 r2 r1 r0 g5 g4 g3 g2 g1 g0 b4 b3 b2 b1 b0 This seems to match DPI_FORMAT_16BIT_565_RGB_1 indeed. Reviewed-by: Laurent Pinchart > Fixes: 08302c35b59d ("drm/vc4: Add DPI driver") > Signed-off-by: Dave Stevenson > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/vc4/vc4_dpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c > index fdae02760b6d..a7bebfa5d5b0 100644 > --- a/drivers/gpu/drm/vc4/vc4_dpi.c > +++ b/drivers/gpu/drm/vc4/vc4_dpi.c > @@ -185,7 +185,7 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder) > DPI_FORMAT); > break; > case MEDIA_BUS_FMT_RGB565_1X16: > - dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_3, > + dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_1, > DPI_FORMAT); > break; > case MEDIA_BUS_FMT_RGB565_1X24_CPADHI: > -- Regards, Laurent Pinchart