From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E040C4332F for ; Wed, 19 Oct 2022 20:30:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231395AbiJSUa4 (ORCPT ); Wed, 19 Oct 2022 16:30:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229697AbiJSUat (ORCPT ); Wed, 19 Oct 2022 16:30:49 -0400 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 646F616E28E for ; Wed, 19 Oct 2022 13:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1666211438; bh=h8gdnH6TPHLdniyPH77+5IDXlOgSi66+RQdogy7SIdQ=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=UkSzLgrrSByqn7txD0Or9TFzu4+Wif1KxCEGmoif6RZKzHfRHQv8nBJeT7PHTvKY3 OjIxNHlt4OZg3fDpTb8dUriq2yS+ozcaRvjQyYEQ9iwbgr+NGl9oRn8AmNjIFFc1zV s/ODtWmUluV+wRw5+IFPdgPqrMAnMBAzDTjY3IGY= Received: by b-1.in.mailobj.net [192.168.90.11] with ESMTP via [213.182.55.206] Wed, 19 Oct 2022 22:30:33 +0200 (CEST) X-EA-Auth: +gJ+6Oke9gLWy6n0iIracjMcGst4KO//gsNkwZYnjitJm1FdFKecL77h26BcCB7pt15OKXSlUmk8HbGnqUPRzDCGOc7WGQWD Date: Thu, 20 Oct 2022 02:00:29 +0530 From: Deepak R Varma To: Julia Lawall Cc: outreachy@lists.linux.dev, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kumarpraveen@linux.microsoft.com, saurabh.truth@gmail.com Subject: Re: [PATCH v4 2/2] staging: most: dim2: correct misleading struct type name Message-ID: References: <6b772a1ac06ae3b0d63e198e7238c1590b14703a.1666208065.git.drv@mailo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 19, 2022 at 10:08:53PM +0200, Julia Lawall wrote: > > > On Thu, 20 Oct 2022, Deepak R Varma wrote: > > > Correct misleading struct type name dim_ch_state_t to dim_ch_state > > since this not a typedef but a normal structure declaration. > > > > Suggested-by: Julia Lawall > > Signed-off-by: Deepak R Varma > > --- > > > > Changes in v4: > > 1. Correct patch subject and log message. Use struct type name instead of > > variable name for the change description. Feedback from julia.lawall@inria.fr > > > > Changes in v3: > > 1. Patch introduced in the patch set > > > > drivers/staging/most/dim2/dim2.c | 2 +- > > drivers/staging/most/dim2/hal.c | 4 ++-- > > drivers/staging/most/dim2/hal.h | 6 +++--- > > 3 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c > > index 4c1f27898a29..a69a61a69283 100644 > > --- a/drivers/staging/most/dim2/dim2.c > > +++ b/drivers/staging/most/dim2/dim2.c > > @@ -161,7 +161,7 @@ static int try_start_dim_transfer(struct hdm_channel *hdm_ch) > > struct list_head *head = &hdm_ch->pending_list; > > struct mbo *mbo; > > unsigned long flags; > > - struct dim_ch_state_t st; > > + struct dim_ch_state st; > > Is there another use in service_done_flag? Hi, I did not understand your question fully. This is from a different function try_start_dim_transfer where the variable st is used down the line in the execution. This time the channel state is retrieved by calling dim_get_channel_state function. The state is simply computed and set. Should I improve this as well? If you are asking something different, could you please elaborate? ./drv > > julia > > > > > BUG_ON(!hdm_ch); > > BUG_ON(!hdm_ch->is_initialized); > > diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c > > index 65282c276862..a5d40b5b138a 100644 > > --- a/drivers/staging/most/dim2/hal.c > > +++ b/drivers/staging/most/dim2/hal.c > > @@ -943,8 +943,8 @@ u8 dim_service_channel(struct dim_channel *ch) > > return channel_service(ch); > > } > > > > -struct dim_ch_state_t *dim_get_channel_state(struct dim_channel *ch, > > - struct dim_ch_state_t *state_ptr) > > +struct dim_ch_state *dim_get_channel_state(struct dim_channel *ch, > > + struct dim_ch_state *state_ptr) > > { > > if (!ch || !state_ptr) > > return NULL; > > diff --git a/drivers/staging/most/dim2/hal.h b/drivers/staging/most/dim2/hal.h > > index 20531449acab..ef10a8741c10 100644 > > --- a/drivers/staging/most/dim2/hal.h > > +++ b/drivers/staging/most/dim2/hal.h > > @@ -27,7 +27,7 @@ enum mlb_clk_speed { > > CLK_8192FS = 7, > > }; > > > > -struct dim_ch_state_t { > > +struct dim_ch_state { > > bool ready; /* Shows readiness to enqueue next buffer */ > > u16 done_buffers; /* Number of completed buffers */ > > }; > > @@ -87,8 +87,8 @@ void dim_service_ahb_int_irq(struct dim_channel *const *channels); > > > > u8 dim_service_channel(struct dim_channel *ch); > > > > -struct dim_ch_state_t *dim_get_channel_state(struct dim_channel *ch, > > - struct dim_ch_state_t *state_ptr); > > +struct dim_ch_state *dim_get_channel_state(struct dim_channel *ch, > > + struct dim_ch_state *state_ptr); > > > > u16 dim_dbr_space(struct dim_channel *ch); > > > > -- > > 2.30.2 > > > > > > > > > >