From: Alexey Dobriyan <adobriyan@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: mm-commits@vger.kernel.org, torvalds@linux-foundation.org,
masahiroy@kernel.org, keescook@chromium.org,
gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com,
Jason@zx2c4.com, akpm@linux-foundation.org
Subject: Re: + kbuild-treat-char-as-always-unsigned.patch added to mm-nonmm-unstable branch
Date: Thu, 20 Oct 2022 12:43:39 +0300 [thread overview]
Message-ID: <Y1EYS/DRjvQd/8t+@localhost.localdomain> (raw)
In-Reply-To: <20221020000356.177CDC433C1@smtp.kernel.org>
On Wed, Oct 19, 2022 at 05:03:55PM -0700, Andrew Morton wrote:
> This will break things in some places and fix things in others, so this
> will likely cause a bit of churn while reconciling the type misuse.
> --- a/Makefile~kbuild-treat-char-as-always-unsigned
> +++ a/Makefile
> @@ -562,7 +562,7 @@ KBUILD_AFLAGS := -D__ASSEMBLY__ -fno-P
> KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
> -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE \
> -Werror=implicit-function-declaration -Werror=implicit-int \
> - -Werror=return-type -Wno-format-security \
> + -Werror=return-type -Wno-format-security -funsigned-char \
> -std=gnu11
> KBUILD_CPPFLAGS := -D__KERNEL__
> KBUILD_RUSTFLAGS := $(rust_common_flags) \
ACK
Another reason is that characters were always some small non-negative
integers which mapped to pictures so making them signed was silly from
the beginning.
People should use "const char *" for C strings and "u8[]" for raw buffers.
Unfortunately, C can't give developer more.
next parent reply other threads:[~2022-10-20 9:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221020000356.177CDC433C1@smtp.kernel.org>
2022-10-20 9:43 ` Alexey Dobriyan [this message]
2022-10-20 9:49 ` [PATCH -mm] -funsigned-char, x86: make struct p4_event_bind::cntr signed array Alexey Dobriyan
2022-10-20 9:56 ` [PATCH -mm] -funsigned-char, namei: delete cast in lookup_one_common() Alexey Dobriyan
2022-10-20 16:28 ` [PATCH -mm] -funsigned-char, x86: make struct p4_event_bind::cntr signed array Jason A. Donenfeld
2022-10-20 17:14 ` Linus Torvalds
2022-10-20 17:33 ` Jason A. Donenfeld
2022-10-20 17:42 ` Linus Torvalds
2022-10-20 18:57 ` Kees Cook
2022-10-20 19:39 ` Linus Torvalds
2022-10-20 20:17 ` Linus Torvalds
2022-10-20 21:34 ` Andy Shevchenko
2022-10-20 22:46 ` Jason A. Donenfeld
2022-10-21 6:48 ` Greg KH
2022-10-21 7:24 ` Jason A. Donenfeld
2022-10-21 7:36 ` Greg KH
2022-10-26 1:50 ` Jason A. Donenfeld
2022-10-26 12:58 ` Jason A. Donenfeld
2022-10-26 13:17 ` Andy Shevchenko
2022-11-02 17:17 ` [cocci] " Julia Lawall
2022-11-03 0:08 ` Jason A. Donenfeld
2022-11-03 6:31 ` Julia Lawall
2022-11-03 12:45 ` Julia Lawall
2022-11-03 12:47 ` Jason A. Donenfeld
2022-11-03 12:57 ` Julia Lawall
2022-11-03 14:07 ` Jason A. Donenfeld
2022-10-24 15:44 ` Jason A. Donenfeld
2022-10-21 5:59 ` Alexey Dobriyan
2022-10-21 17:11 ` Linus Torvalds
2022-10-21 17:23 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1EYS/DRjvQd/8t+@localhost.localdomain \
--to=adobriyan@gmail.com \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome