From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D746CC433FE for ; Thu, 20 Oct 2022 12:56:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230126AbiJTM4g (ORCPT ); Thu, 20 Oct 2022 08:56:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229915AbiJTM42 (ORCPT ); Thu, 20 Oct 2022 08:56:28 -0400 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17571148F51 for ; Thu, 20 Oct 2022 05:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1666270576; bh=duRMsrf/gJ7eie8q7NwBQZsK46u4dqLgK9IzhR286ik=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=k1ZMMcqFHwn/r84X+NBia1cQtwpT+tc8fizY1FbI3tyBftJBUExjd6/z2LEehkaQo mumawSv6tN0xfUN6J1gxnbPlDfYp7amUZnw8+TOyDSVsvKuyocaf0gxijr8qWLnV5c 2rpSDNk6PVusk/kLfGATqNVIizzch93J0ZuTv9/0= Received: by b-1.in.mailobj.net [192.168.90.11] with ESMTP via [213.182.55.206] Thu, 20 Oct 2022 14:56:16 +0200 (CEST) X-EA-Auth: AlTAwPZszBxM1uQBnXrH9iLqAFvpsaWg3rmVNN9Wnhue8gs3W50bHpDCKoKsIAiY6x1b92R8GsmPP7c7aY0iGD4rRILIiyZc Date: Thu, 20 Oct 2022 18:26:12 +0530 From: Deepak R Varma To: Julia Lawall Cc: outreachy@lists.linux.dev, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kumarpraveen@linux.microsoft.com, saurabh.truth@gmail.com Subject: Re: [PATCH v4 2/2] staging: most: dim2: correct misleading struct type name Message-ID: References: <6b772a1ac06ae3b0d63e198e7238c1590b14703a.1666208065.git.drv@mailo.com> <404cc67c-efd6-4a70-c3ca-7958db21bcb@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <404cc67c-efd6-4a70-c3ca-7958db21bcb@inria.fr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 20, 2022 at 02:06:41PM +0200, Julia Lawall wrote: > > > On Thu, 20 Oct 2022, Deepak R Varma wrote: > > > On Thu, Oct 20, 2022 at 02:00:29AM +0530, Deepak R Varma wrote: > > > On Wed, Oct 19, 2022 at 10:08:53PM +0200, Julia Lawall wrote: > > > > > > > > > > > > On Thu, 20 Oct 2022, Deepak R Varma wrote: > > > > > > > > > Correct misleading struct type name dim_ch_state_t to dim_ch_state > > > > > since this not a typedef but a normal structure declaration. > > > > > > > > > > Suggested-by: Julia Lawall > > > > > Signed-off-by: Deepak R Varma > > > > > --- > > > > > > > > > > Changes in v4: > > > > > 1. Correct patch subject and log message. Use struct type name instead of > > > > > variable name for the change description. Feedback from julia.lawall@inria.fr > > > > > > > > > > Changes in v3: > > > > > 1. Patch introduced in the patch set > > > > > > > > > > drivers/staging/most/dim2/dim2.c | 2 +- > > > > > drivers/staging/most/dim2/hal.c | 4 ++-- > > > > > drivers/staging/most/dim2/hal.h | 6 +++--- > > > > > 3 files changed, 6 insertions(+), 6 deletions(-) > > > > > > > > > > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c > > > > > index 4c1f27898a29..a69a61a69283 100644 > > > > > --- a/drivers/staging/most/dim2/dim2.c > > > > > +++ b/drivers/staging/most/dim2/dim2.c > > > > > @@ -161,7 +161,7 @@ static int try_start_dim_transfer(struct hdm_channel *hdm_ch) > > > > > struct list_head *head = &hdm_ch->pending_list; > > > > > struct mbo *mbo; > > > > > unsigned long flags; > > > > > - struct dim_ch_state_t st; > > > > > + struct dim_ch_state st; > > > > > > > > Is there another use in service_done_flag? > > > > > > Hi, > > > I did not understand your question fully. This is from a different function > > > try_start_dim_transfer where the variable st is used down the line in the > > > execution. This time the channel state is retrieved by calling > > > dim_get_channel_state function. The state is simply computed and set. Should I > > > improve this as well? > > > > > > If you are asking something different, could you please elaborate? > > > > Hi Julia, > > Can you please review and comment on my response? > > In my kernel there is an occurrence of the type name in service_done_flag. > But I have the mainline, not Greg's staging tree, so there could be some > differences. > > When I do git grep dim_ch_state_t, I get two occurrences in > drivers/staging/most/dim2/dim2.c Okay. Still unclear. Following snip is what I see in my local staging-testing branch. drv@debian:~/git/kernels/staging$ git grep dim_ch_state_t drivers/staging/most/dim2/dim2.c: struct dim_ch_state_t st; drivers/staging/most/dim2/dim2.c: struct dim_ch_state_t st; drivers/staging/most/dim2/hal.c:struct dim_ch_state_t *dim_get_channel_state(struct dim_channel *ch, drivers/staging/most/dim2/hal.c: struct dim_ch_state_t *state_ptr) drivers/staging/most/dim2/hal.h:struct dim_ch_state_t { drivers/staging/most/dim2/hal.h:struct dim_ch_state_t *dim_get_channel_state(struct dim_channel *ch, drivers/staging/most/dim2/hal.h: struct dim_ch_state_t *state_ptr); drv@debian:~/git/kernels/staging$ Does that help? ./drv > > julia