From: Herbert Xu <herbert@gondor.apana.org.au>
To: Zhiqi Song <songzhiqi1@huawei.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, wangzhou1@hisilicon.com,
fanghao11@huawei.com, liulongfang@huawei.com
Subject: Re: [PATCH] crypto: hisilicon/hpre - fix resource leak in remove process
Date: Fri, 21 Oct 2022 19:32:15 +0800 [thread overview]
Message-ID: <Y1KDP6HuPrckDWFg@gondor.apana.org.au> (raw)
In-Reply-To: <20220924073831.38479-1-songzhiqi1@huawei.com>
On Sat, Sep 24, 2022 at 03:38:31PM +0800, Zhiqi Song wrote:
> In hpre_remove(), when the disable operation of qm sriov failed,
> the following logic should continue to be executed to release the
> remaining resources that have been allocated, instead of returning
> directly, otherwise there will be resource leakage.
>
> Signed-off-by: Zhiqi Song <songzhiqi1@huawei.com>
> ---
> drivers/crypto/hisilicon/hpre/hpre_main.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2022-10-21 11:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-24 7:38 Zhiqi Song
2022-10-21 11:32 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1KDP6HuPrckDWFg@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=fanghao11@huawei.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liulongfang@huawei.com \
--cc=songzhiqi1@huawei.com \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®