From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA3E9C38A2D for ; Fri, 21 Oct 2022 21:18:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230045AbiJUVSX (ORCPT ); Fri, 21 Oct 2022 17:18:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230139AbiJUVSS (ORCPT ); Fri, 21 Oct 2022 17:18:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9387A2A4E24 for ; Fri, 21 Oct 2022 14:18:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D6C2561F8E for ; Fri, 21 Oct 2022 21:18:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A7D7C433D6; Fri, 21 Oct 2022 21:18:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666387094; bh=lNMTqMjhK1y8wiMz79oWkjOtjdhIp9WkAVwBJUh/kaU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hh8YtN8AxnWUGkIkwfNjdnp3qyCNqcD/fifW3dmMQ2+g/DJHBOuem4WYf1CENjENw fm9/pZlUuwvAZKnTb1ZGFo9fGjiNA8cJoN2LmQSSzwk91+wdWnpoSdS6bivUhAhuoR WPAaLexRQR9SrWLIHcEPeXOJdTmFcRUarNadK5KGL7P4P9tMPNaXs6CKVhpCSQeyPU pwp8qFuxO1qNaolj6HmLAovHhZrawy4I7nTg43t8XwEGHTEo7SkZNV2pjm3YO7tlUU MXiWTvq8Mhvdjz5NFjmtuQiLupn4BdbEWZcDloW4xOX/u6SPNvEVQjeLBljj+UftEa onMMxnqzse3qw== Date: Fri, 21 Oct 2022 14:18:12 -0700 From: Nathan Chancellor To: Miguel Ojeda Cc: Andrey Konovalov , Marco Elver , Kees Cook , Arnd Bergmann , Andrew Morton , Kumar Kartikeya Dwivedi , Nick Desaulniers , Uros Bizjak , Dan Li , Alexander Potapenko , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] compiler-gcc: remove attribute support check for `__no_sanitize_address__` Message-ID: References: <20221021115956.9947-1-ojeda@kernel.org> <20221021115956.9947-2-ojeda@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221021115956.9947-2-ojeda@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 21, 2022 at 01:59:53PM +0200, Miguel Ojeda wrote: > The attribute was added in GCC 4.8, while the minimum GCC version > supported by the kernel is GCC 5.1. > > Therefore, remove the check. > > Link: https://godbolt.org/z/84v56vcn8 > Signed-off-by: Miguel Ojeda Reviewed-by: Nathan Chancellor > --- > include/linux/compiler-gcc.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h > index b9530d3515ac..bfce7f4d0978 100644 > --- a/include/linux/compiler-gcc.h > +++ b/include/linux/compiler-gcc.h > @@ -82,11 +82,7 @@ > #define __noscs __attribute__((__no_sanitize__("shadow-call-stack"))) > #endif > > -#if __has_attribute(__no_sanitize_address__) > #define __no_sanitize_address __attribute__((__no_sanitize_address__)) > -#else > -#define __no_sanitize_address > -#endif > > #if defined(__SANITIZE_THREAD__) && __has_attribute(__no_sanitize_thread__) > #define __no_sanitize_thread __attribute__((__no_sanitize_thread__)) > -- > 2.38.1 > >