mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Dumazet <edumazet@google.com>
Cc: syzbot <syzbot+1e9af9185d8850e2c2fa@syzkaller.appspotmail.com>,
	davem@davemloft.net, kuba@kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	pabeni@redhat.com, steffen.klassert@secunet.com,
	syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] kernel BUG in warn_crc32c_csum_combine
Date: Mon, 24 Oct 2022 13:01:31 +0800	[thread overview]
Message-ID: <Y1YcK0LPqP5nan40@gondor.apana.org.au> (raw)
In-Reply-To: <CANn89iJdYrAsp8X61ojw=ZVPEZeYu2vWaTcyDQL8NQ5aZW+8cA@mail.gmail.com>

On Sun, Oct 23, 2022 at 07:49:44PM -0700, Eric Dumazet wrote:
>
> pfkey_send_acquire() allocates and skb, and then later this skb seems
> to be too small to fit all dump info.
> 
> Maybe ->available status flips during the duration of the call ?
> 
> (So count_esp_combs() might return a value, but later dump_esp_combs()
> needs more space)

Thanks!

> Relevant patch suggests this could happen
> 
> commit ba953a9d89a00c078b85f4b190bc1dde66fe16b5
> Author: Herbert Xu <herbert@gondor.apana.org.au>
> Date:   Thu Aug 4 18:03:46 2022 +0800
> 
>     af_key: Do not call xfrm_probe_algs in parallel

Yes this looks like the same issue just in a different spot.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2022-10-24  5:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24  2:37 syzbot
2022-10-24  2:49 ` Eric Dumazet
2022-10-24  5:01   ` Herbert Xu [this message]
2022-10-24  5:10 ` [PATCH] af_key: Fix send_acquire race with pfkey_register Herbert Xu
2022-10-24  5:21   ` Eric Dumazet
2022-10-24  6:06     ` [v2 PATCH] " Herbert Xu
2022-10-24  6:31       ` Eric Dumazet
2022-10-25  5:46         ` Herbert Xu
2022-10-24  7:20       ` Sabrina Dubroca
2022-10-25  6:06         ` [v3 " Herbert Xu
2022-10-26 13:38           ` Sabrina Dubroca
2022-10-27  3:42             ` Herbert Xu
2022-10-27  3:45               ` Eric Dumazet
2022-10-27  3:55                 ` Herbert Xu
2022-10-28 11:26                 ` Steffen Klassert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1YcK0LPqP5nan40@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=steffen.klassert@secunet.com \
    --cc=syzbot+1e9af9185d8850e2c2fa@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®