From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB990ECAAA1 for ; Mon, 24 Oct 2022 12:35:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234095AbiJXMdx (ORCPT ); Mon, 24 Oct 2022 08:33:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234140AbiJXM3Y (ORCPT ); Mon, 24 Oct 2022 08:29:24 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA0ED13F8F; Mon, 24 Oct 2022 05:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666613003; x=1698149003; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=CfmKsPPFEZz3JYfcGzvUpUe5DGAdjt5IdWHUUS6XAEs=; b=dmWZYRFA91f6Ed2pGUxy8ykbOWmOEk7oyxmtZEGToGJX7N6oCdh01SwU RU++LYZ3H7nn/rfUBvUp3n4MIBcTS9XBxeknyfQYwiD9FRT8dkfMOPf9C NJY7taDADtXIc1Y1fpdOsWpYAkpcvo/ocThsvoZVZrpZk5nBvo3a1xu1Z LRRL++tix6RmgTGQBwh2gXW+KRyDtIurTfQ0IYurR70v9dhlNrB9axGNi enTJnD/Ug9zhCMKGYTtchYBs34JHisP07s8zHxzfY+PTzqZjPAbUJpPgT dZ1qkMQilZlMDg5hlseGWpkejtooGpK4yKJONeMtkIbEm/t94GxlF1n3k A==; X-IronPort-AV: E=McAfee;i="6500,9779,10509"; a="305008264" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="305008264" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 05:00:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10509"; a="633684800" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="633684800" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP; 24 Oct 2022 05:00:31 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1omw84-001QQC-1P; Mon, 24 Oct 2022 15:00:28 +0300 Date: Mon, 24 Oct 2022 15:00:28 +0300 From: Andy Shevchenko To: Dongliang Mu Cc: Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chris Packham , Damien Le Moal , Wolfram Sang , Michael Ellerman , Cai Huoqing , Christophe Leroy , Gerhard Sittig , Anatolij Gustschin , Mark Brown , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] can: mscan: mpc5xxx: fix error handling code in mpc5xxx_can_probe Message-ID: References: <20221024114810.732168-1-dzm91@hust.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221024114810.732168-1-dzm91@hust.edu.cn> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 24, 2022 at 07:48:07PM +0800, Dongliang Mu wrote: > The commit 1149108e2fbf ("can: mscan: improve clock API use > ") only adds put_clock in mpc5xxx_can_remove function, forgetting to add Strange indentation. Why the '")' part can't be on the previous line? > put_clock in the error handling code. > > Fix this bug by adding put_clock in the error handling code. -- With Best Regards, Andy Shevchenko