From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D2D3C38A2D for ; Mon, 24 Oct 2022 16:36:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230300AbiJXQgz (ORCPT ); Mon, 24 Oct 2022 12:36:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233761AbiJXQgT (ORCPT ); Mon, 24 Oct 2022 12:36:19 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35F9918D47D; Mon, 24 Oct 2022 08:23:53 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2DEB88BF; Mon, 24 Oct 2022 17:12:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1666624359; bh=XynA4ysgfEg2/idRBdKxuEVP9aT5qllM1ojw2hUTpSw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ufYo+6pP3UUZQMwQ+T7GXvYnXwNgM4htrPA+NCqg9RpoPEh2Gyb3uY/2Fz5E2ETbm p46TiJyLWoQ/bGEi5Oxo65pn9do2Vcv6UAgP6/O3gZVNJs2MTjdVy0zmBbZLJpx0QT m+aOT43JUTD7lxQOSSLj5bToXb/938sp+LQ4L92o= Date: Mon, 24 Oct 2022 18:12:14 +0300 From: Laurent Pinchart To: Gabriel Lima Luz Cc: Rui Miguel Silva , Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: Re: [PATCH] staging: media: imx: imx7-media-csi: Fix parenthesis alignment Message-ID: References: <20221024150744.72641-1-lima.gabriel.luz@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221024150744.72641-1-lima.gabriel.luz@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gabriel, Thank you for the patch. On Mon, Oct 24, 2022 at 12:07:44PM -0300, Gabriel Lima Luz wrote: > Adhere to Linux kernel coding style. > > Reported by checkpatch: > > CHECK: Alignment should match open parenthesis > > Signed-off-by: Gabriel Lima Luz > --- > drivers/staging/media/imx/imx7-media-csi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c > index cbc66ef0eda8..9ad7205a3f2f 100644 > --- a/drivers/staging/media/imx/imx7-media-csi.c > +++ b/drivers/staging/media/imx/imx7-media-csi.c > @@ -1704,7 +1704,7 @@ static int imx7_csi_init_cfg(struct v4l2_subdev *sd, > mf->xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(mf->colorspace); > mf->ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(mf->colorspace); > mf->quantization = V4L2_MAP_QUANTIZATION_DEFAULT(!cc->yuv, > - mf->colorspace, mf->ycbcr_enc); > + mf->colorspace, mf->ycbcr_enc); I think this is a valid exception to the coding style, to increase readability by avoiding long lines. Otherwise, I'd wrap it as mf->quantization = V4L2_MAP_QUANTIZATION_DEFAULT(!cc->yuv, mf->colorspace, mf->ycbcr_enc); > > csi->cc[i] = cc; > } -- Regards, Laurent Pinchart