From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FCEFC38A2D for ; Wed, 26 Oct 2022 13:45:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233658AbiJZNpQ (ORCPT ); Wed, 26 Oct 2022 09:45:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233672AbiJZNpG (ORCPT ); Wed, 26 Oct 2022 09:45:06 -0400 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95D281D0E8 for ; Wed, 26 Oct 2022 06:44:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1666791886; bh=ysuEu2gcIIZ9Gls3WpW2bMj8egi1afgluP/NBc5EWnw=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=HmW0HhlZBEtQaXq4byFmXum8bkT8E96SObxAfid3j2s2cB79r4Yo29QJT5ip/cWxf hPTcI+GQvnVGwAkFGPxQF7mS8PlZN04v9OQhGspAbZI5gaELFtlATFWXnKRuIzQEO9 XWCdXikR3FZwDtb6+MJzO0+Eby3yV/jBzzT0aDtY= Received: by b-5.in.mailobj.net [192.168.90.15] with ESMTP via [213.182.55.206] Wed, 26 Oct 2022 15:44:46 +0200 (CEST) X-EA-Auth: N64AvuwQIp1I6Tw9cugKwmAqQwT+msEiS9FYfZa5FQBqVXeGcp75mkjIq995/MNmMfQMYPIEE1BZ3hgkWpENz5mYrJibjHPf Date: Wed, 26 Oct 2022 19:14:43 +0530 From: Deepak R Varma To: Greg Kroah-Hartman Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: rtl8192u: remove unused macro definition Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 26, 2022 at 03:14:23PM +0200, Greg Kroah-Hartman wrote: > On Wed, Oct 26, 2022 at 08:58:44AM +0530, Deepak R Varma wrote: > > Pre-processor macros that are defined but are never used should be > > cleaned up to avoid unexpected usage. > > > > Signed-off-by: Deepak R Varma > > --- > > drivers/staging/rtl8192u/ieee80211/ieee80211.h | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h > > index 00c07455cbb3..0b3dda59d7c0 100644 > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h > > @@ -230,8 +230,6 @@ struct cb_desc { > > #define ieee80211_unregister_crypto_ops ieee80211_unregister_crypto_ops_rsl > > #define ieee80211_get_crypto_ops ieee80211_get_crypto_ops_rsl > > > > -#define ieee80211_ccmp_null ieee80211_ccmp_null_rsl > > - > > #define free_ieee80211 free_ieee80211_rsl > > #define alloc_ieee80211 alloc_ieee80211_rsl > > These #defines are a mess, please look into unwinding them as they > should not be needed at all. Hello Greg, I would like to know what you mean by "unwind them". Is there a documentation or past commit that I can review to understand the expectations better? Thank you, ./drv > > thanks, > > greg k-h >