From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AF3FFA3742 for ; Thu, 27 Oct 2022 12:16:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235085AbiJ0MQI (ORCPT ); Thu, 27 Oct 2022 08:16:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234698AbiJ0MQF (ORCPT ); Thu, 27 Oct 2022 08:16:05 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AAB92DCE92 for ; Thu, 27 Oct 2022 05:16:03 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B80D023A; Thu, 27 Oct 2022 05:16:09 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.1.184]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 07EE03F7B4; Thu, 27 Oct 2022 05:16:01 -0700 (PDT) Date: Thu, 27 Oct 2022 13:15:59 +0100 From: Mark Rutland To: Johan Hovold , Sudeep Holla Cc: Lorenzo Pieralisi , Ulf Hansson , Dmitry Baryshkov , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] firmware/psci: demote suspend-mode warning to info level Message-ID: References: <20221026135445.8004-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221026135445.8004-1-johan+linaro@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 26, 2022 at 03:54:45PM +0200, Johan Hovold wrote: > On some Qualcomm platforms, like SC8280XP, the attempt to set PC mode > during boot fails with PSCI_RET_DENIED and since commit 998fcd001feb > ("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this > is now logged at warning level: > > psci: failed to set PC mode: -3 > > As there is nothing users can do about the firmware behaving this way, > demote the warning to info level and clearly mark it as a firmware bug: > > psci: [Firmware Bug]: failed to set PC mode: -3 > > Signed-off-by: Johan Hovold On the assumption that we don't have any latent issues in this case, this looks ok to me, so: Acked-by: Mark Rutland Sudeep, does this reasonable to you? Are there any latent issues that mean we should keep this as a pr_warn()? Thanks, Mark. > --- > drivers/firmware/psci/psci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > index e7bcfca4159f..f8fa32f0a130 100644 > --- a/drivers/firmware/psci/psci.c > +++ b/drivers/firmware/psci/psci.c > @@ -165,7 +165,8 @@ int psci_set_osi_mode(bool enable) > > err = invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE, suspend_mode, 0, 0); > if (err < 0) > - pr_warn("failed to set %s mode: %d\n", enable ? "OSI" : "PC", err); > + pr_info(FW_BUG "failed to set %s mode: %d\n", > + enable ? "OSI" : "PC", err); > return psci_to_linux_errno(err); > } > > -- > 2.37.3 >