From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EF24C4332F for ; Thu, 10 Nov 2022 18:07:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231577AbiKJSG4 (ORCPT ); Thu, 10 Nov 2022 13:06:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230168AbiKJSGn (ORCPT ); Thu, 10 Nov 2022 13:06:43 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2393713F93; Thu, 10 Nov 2022 10:06:43 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ADC9B61DE9; Thu, 10 Nov 2022 18:06:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9630FC433C1; Thu, 10 Nov 2022 18:06:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1668103602; bh=ymv93fw8232T14FWYerOXLO1Sz8xk73G0SrPUp5YyFk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=w0ZgmvOVNVz88EXwMg6+3V2sp0eufwrD5nFsj/vWptph9gzMbo82Aty5S3v1zcZkL KGxC18QCrb4plIrQDE0IRqqN6KTEAQUtXGYaPZLrbm4L2K3hACbd7fycbgOckOqdsf fz32MmuoS5QixOs/P2/CTw4tyaj2NDJbQemj2rtg= Date: Thu, 10 Nov 2022 19:06:39 +0100 From: Greg KH To: Kumaravel.Thiagarajan@microchip.com Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, jirislaby@kernel.org, andriy.shevchenko@linux.intel.com, ilpo.jarvinen@linux.intel.com, macro@orcam.me.uk, jay.dolan@accesio.com, cang1@live.co.uk, u.kleine-koenig@pengutronix.de, wander@redhat.com, etremblay@distech-controls.com, jk@ozlabs.org, biju.das.jz@bp.renesas.com, geert+renesas@glider.be, phil.edworthy@renesas.com, lukas@wunner.de, UNGLinuxDriver@microchip.com Subject: Re: [PATCH v3 tty-next 1/3] 8250: microchip: pci1xxxx: Add driver for quad-uart support. Message-ID: References: <20221107124517.1364484-1-kumaravel.thiagarajan@microchip.com> <20221107124517.1364484-2-kumaravel.thiagarajan@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 10, 2022 at 05:18:46PM +0000, Kumaravel.Thiagarajan@microchip.com wrote: > > -----Original Message----- > > From: Greg KH > > Sent: Wednesday, November 9, 2022 5:31 PM > > To: Kumaravel Thiagarajan - I21417 > > Subject: Re: [PATCH v3 tty-next 1/3] 8250: microchip: pci1xxxx: Add driver for > > quad-uart support. > > > > On Mon, Nov 07, 2022 at 06:15:15PM +0530, Kumaravel Thiagarajan wrote: > > > +++ b/drivers/tty/serial/8250/8250_pcilib.c > > > @@ -0,0 +1,31 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* Microchip pci1xxxx 8250 library. */ > > > > Better name and a copyright line? > Yes Greg. I think "8250 PCI library" would be the correct name. Is that fine? That would be good as obviously it's not a microchip-only thing here. > Regarding the copyright, we moved the "setup_port" function from 8250_pci.c to this new file. > Can I use the same copyright statement from 8250_pci.c "Copyright (C) 2001 Russell King, All Rights Reserved."? Yes, that would be good. thanks, greg k-h