From: "Gabriel L. Somlo" <gsomlo@gmail.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-serial <linux-serial@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
kgugala@antmicro.com, mholenko@antmicro.com, joel@jms.id.au,
david.abdurachmanov@gmail.com, florent@enjoy-digital.fr,
geert@linux-m68k.org
Subject: Re: [PATCH v2 6/7] serial: liteuart: separate RX loop from poll timer
Date: Thu, 10 Nov 2022 15:29:30 -0500 [thread overview]
Message-ID: <Y21fKt+mGKvQ8yMF@glsvmlin.ini.cmu.edu> (raw)
In-Reply-To: <1c902ee8-d33d-c2d0-7eef-719f59f3a64@linux.intel.com>
On Thu, Nov 10, 2022 at 01:01:47PM +0200, Ilpo Järvinen wrote:
> On Wed, 9 Nov 2022, Gabriel Somlo wrote:
>
> > Move the character-receive (RX) loop to its own dedicated function,
> > and (for now) call that from the poll timer, liteuart_timer().
> >
> > This is in preparation for adding IRQ support to the receive path.
> >
> > Signed-off-by: Gabriel Somlo <gsomlo@gmail.com>
> > ---
> > drivers/tty/serial/liteuart.c | 25 +++++++++++++++----------
> > 1 file changed, 15 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
> > index 047d5ad32e13..aa7052280197 100644
> > --- a/drivers/tty/serial/liteuart.c
> > +++ b/drivers/tty/serial/liteuart.c
> > @@ -67,29 +67,34 @@ static struct uart_driver liteuart_driver = {
> > #endif
> > };
> >
> > -static void liteuart_timer(struct timer_list *t)
> > +static void liteuart_rx_chars(struct uart_port *port)
> > {
> > - struct liteuart_port *uart = from_timer(uart, t, timer);
> > - struct uart_port *port = &uart->port;
> > unsigned char __iomem *membase = port->membase;
> > - unsigned int flg = TTY_NORMAL;
> > - int ch;
> > - unsigned long status;
> > + unsigned int status;
> > + unsigned char ch;
> >
> > while ((status = !litex_read8(membase + OFF_RXEMPTY)) == 1) {
> > ch = litex_read8(membase + OFF_RXTX);
> > port->icount.rx++;
> >
> > /* necessary for RXEMPTY to refresh its value */
> > - litex_write8(membase + OFF_EV_PENDING, EV_TX | EV_RX);
> > + litex_write8(membase + OFF_EV_PENDING, EV_RX);
> >
> > /* no overflow bits in status */
> > if (!(uart_handle_sysrq_char(port, ch)))
> > - uart_insert_char(port, status, 0, ch, flg);
> > -
> > - tty_flip_buffer_push(&port->state->port);
> > + uart_insert_char(port, status, 0, ch, TTY_NORMAL);
> > }
> >
> > + tty_flip_buffer_push(&port->state->port);
>
> This change is doing extra stuff besides moving rx to a dedicated
> function.
>
> I see no reason why those other changes couldn't be put into an entirely
> separate patch. Also, please described those changes properly in the
> commit message (answer the why? question).
You're right, calling `tty_flip_buffer_push()` as each character is
received is overkill, we only need to call it once per interrupt once
all available characters have been received.
I forgot I noticed (and fixed) that as part of the move -- I'll split
it out into its own separate patch (probably *before* moving all of rx
to a dedicated function).
Should show up in v3, once I also address all the other feedback I
received.
Thanks again for catching it!
Cheers,
-Gabriel
> --
> i.
>
> > +}
> > +
> > +static void liteuart_timer(struct timer_list *t)
> > +{
> > + struct liteuart_port *uart = from_timer(uart, t, timer);
> > + struct uart_port *port = &uart->port;
> > +
> > + liteuart_rx_chars(port);
> > +
> > mod_timer(&uart->timer, jiffies + uart_poll_timeout(port));
> > }
> >
> >
>
>
next prev parent reply other threads:[~2022-11-10 20:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 0:44 [PATCH v2 0/7] serial: liteuart: add IRQ support Gabriel Somlo
2022-11-10 0:44 ` [PATCH v2 1/7] serial: liteuart: use KBUILD_MODNAME as driver name Gabriel Somlo
2022-11-10 0:44 ` [PATCH v2 2/7] serial: liteuart: use bit number macros Gabriel Somlo
2022-11-10 0:44 ` [PATCH v2 3/7] serial: liteuart: remove unused uart_ops stubs Gabriel Somlo
2022-11-10 0:44 ` [PATCH v2 4/7] serial: liteuart: don't set unused port fields Gabriel Somlo
2022-11-10 0:44 ` [PATCH v2 5/7] serial: liteuart: minor style fix in liteuart_init() Gabriel Somlo
2022-11-10 0:44 ` [PATCH v2 6/7] serial: liteuart: separate RX loop from poll timer Gabriel Somlo
2022-11-10 11:01 ` Ilpo Järvinen
2022-11-10 20:29 ` Gabriel L. Somlo [this message]
2022-11-10 0:44 ` [PATCH v2 7/7] serial: liteuart: add IRQ support Gabriel Somlo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y21fKt+mGKvQ8yMF@glsvmlin.ini.cmu.edu \
--to=gsomlo@gmail.com \
--cc=david.abdurachmanov@gmail.com \
--cc=florent@enjoy-digital.fr \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=joel@jms.id.au \
--cc=kgugala@antmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mholenko@antmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®