mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yan Zhao <yan.y.zhao@intel.com>
To: Sean Christopherson <seanjc@google.com>
Cc: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<pbonzini@redhat.com>
Subject: Re: [PATCH] KVM: x86/mmu: avoid accidentally go to shadow path for 0 count tdp root
Date: Fri, 11 Nov 2022 09:40:54 +0800	[thread overview]
Message-ID: <Y22oJhrIxSgkMrj4@yzhao56-desk.sh.intel.com> (raw)
In-Reply-To: <Y20svCKydu/iS0TY@google.com>

On Thu, Nov 10, 2022 at 04:54:20PM +0000, Sean Christopherson wrote:
> On Thu, Nov 10, 2022, Yan Zhao wrote:
> > kvm mmu uses "if (is_tdp_mmu(vcpu->arch.mmu))" to choose between tdp mmu
> > and shadow path.
> > If a root is a tdp mmu page while its root_count is 0, it's not valid to
> > go to the shadow path.
> > 
> > So, return true and add a warn on zero root count.
> > 
> > Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
> > ---
> >  arch/x86/kvm/mmu/tdp_mmu.h | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/x86/kvm/mmu/tdp_mmu.h b/arch/x86/kvm/mmu/tdp_mmu.h
> > index c163f7cc23ca..58b4881654a9 100644
> > --- a/arch/x86/kvm/mmu/tdp_mmu.h
> > +++ b/arch/x86/kvm/mmu/tdp_mmu.h
> > @@ -74,6 +74,7 @@ static inline bool is_tdp_mmu(struct kvm_mmu *mmu)
> >  {
> >  	struct kvm_mmu_page *sp;
> >  	hpa_t hpa = mmu->root.hpa;
> > +	bool is_tdp;
> >  
> >  	if (WARN_ON(!VALID_PAGE(hpa)))
> >  		return false;
> > @@ -84,7 +85,10 @@ static inline bool is_tdp_mmu(struct kvm_mmu *mmu)
> >  	 * pae_root page, not a shadow page.
> >  	 */
> >  	sp = to_shadow_page(hpa);
> > -	return sp && is_tdp_mmu_page(sp) && sp->root_count;
> > +	is_tdp = sp && is_tdp_mmu_page(sp);
> > +	WARN_ON(is_tdp && !refcount_read(&sp->tdp_mmu_root_count));
> > +
> > +	return is_tdp;
> 
> I have a series/patch that drops this code entirely, I would rather just go that
> route directly.
> 
> https://lore.kernel.org/all/20221012181702.3663607-9-seanjc@google.com
Thanks for pointing me to this link.
Yes, it's a much better fix!

Thanks
Yan


      reply	other threads:[~2022-11-11  2:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10  3:41 Yan Zhao
2022-11-10 16:54 ` Sean Christopherson
2022-11-11  1:40   ` Yan Zhao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y22oJhrIxSgkMrj4@yzhao56-desk.sh.intel.com \
    --to=yan.y.zhao@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®