From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 089E5C433FE for ; Tue, 1 Nov 2022 13:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229826AbiKANed (ORCPT ); Tue, 1 Nov 2022 09:34:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229601AbiKANeL (ORCPT ); Tue, 1 Nov 2022 09:34:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD61B1156; Tue, 1 Nov 2022 06:34:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 52DB161452; Tue, 1 Nov 2022 13:34:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67B09C433D6; Tue, 1 Nov 2022 13:34:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1667309649; bh=lCCeOtXrB+VyAf+ZkJOVzx63oP7fC/Cq3ISVXHAAfr8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=REBbclWjlsoZUgfhWVDKwCSBCo0fV0NG/i6DrDr9xGymYY9glAxaevf5/z1nKtCkd 6sBgfy/f6I+ouVqIyh7iG1Wm6IYrhczlEOMvtHfXYdCNVGuZ2AIltwceK5r81uRXvv sAgkvhQaUH95MJELg3ATeln9QH8ZPD4J+n1Hh9Cc= Date: Tue, 1 Nov 2022 14:35:03 +0100 From: Greg Kroah-Hartman To: Yongqin Liu Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Christophe Leroy , Eric Dumazet , Willy Tarreau , "David S. Miller" , Sasha Levin , Sumit Semwal , Benjamin Copeland , Daniel =?iso-8859-1?Q?D=EDaz?= Subject: Re: [PATCH 4.19 092/229] once: add DO_ONCE_SLOW() for sleepable contexts Message-ID: References: <20221024112959.085534368@linuxfoundation.org> <20221024113002.025977656@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 01, 2022 at 08:00:03PM +0800, Yongqin Liu wrote: > Hi, Greg > > On Tue, 1 Nov 2022 at 14:26, Greg Kroah-Hartman > wrote: > > > > On Tue, Nov 01, 2022 at 02:07:35PM +0800, Yongqin Liu wrote: > > > Hello, > > > > > > As mentioned in the thread for the 5.4 version here[1], it causes a > > > crash for the 4.19 kernel too. > > > Just paste the log here for reference: > > > > Can you try this patch please: > > > > > > diff --git a/include/linux/once.h b/include/linux/once.h > > index bb58e1c3aa03..3a6671d961b9 100644 > > --- a/include/linux/once.h > > +++ b/include/linux/once.h > > @@ -64,7 +64,7 @@ void __do_once_slow_done(bool *done, struct static_key_true *once_key, > > #define DO_ONCE_SLOW(func, ...) \ > > ({ \ > > bool ___ret = false; \ > > - static bool __section(".data.once") ___done = false; \ > > + static bool __section(.data.once) ___done = false; \ > > static DEFINE_STATIC_KEY_TRUE(___once_key); \ > > if (static_branch_unlikely(&___once_key)) { \ > > ___ret = __do_once_slow_start(&___done); \ > > > This change works, it does not cause kernel panic again after this > change is applied. Great, thanks! Can I get a Tested-by: line for the changelog? I'll queue this up in a bit and get it fixed in the next release. thanks, greg k-h