From: Andrew Lunn <andrew@lunn.ch>
To: Andy Ren <andy.ren@getcruise.com>
Cc: netdev@vger.kernel.org, davem@davemloft.com, kuba@kernel.org,
pabeni@redhat.com, corbet@lwm.net, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, roman.gushchin@linux.dev
Subject: Re: [PATCH net-next] netconsole: Enable live renaming for network interfaces used by netconsole
Date: Tue, 1 Nov 2022 21:04:23 +0100 [thread overview]
Message-ID: <Y2F7x319oanq/+i1@lunn.ch> (raw)
In-Reply-To: <20221101181225.1272144-1-andy.ren@getcruise.com>
> where
> + if present, enable extended console support
> src-port source for UDP packets (defaults to 6665)
> src-ip source IP to use (interface address)
> dev network interface (eth0)
> + * if present, allow runtime network interface renaming
> tgt-port port for logging agent (6666)
> tgt-ip IP address for logging agent
> tgt-macaddr ethernet MAC address for logging agent (broadcast)
>
> Examples::
>
> - linux netconsole=4444@10.0.0.1/eth1,9353@10.0.0.2/12:34:56:78:9a:bc
> + linux netconsole=4444@10.0.0.1/eth1*,9353@10.0.0.2/12:34:56:78:9a:bc
To me, this looks like a wildcard of the interface name.
Maybe move the position of the *. Put it after the + ?
Andrew
next prev parent reply other threads:[~2022-11-01 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 18:12 Andy Ren
2022-11-01 20:04 ` Andrew Lunn [this message]
2022-11-01 18:40 Andy Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2F7x319oanq/+i1@lunn.ch \
--to=andrew@lunn.ch \
--cc=andy.ren@getcruise.com \
--cc=corbet@lwm.net \
--cc=davem@davemloft.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roman.gushchin@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®