From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87E4DC4332F for ; Wed, 2 Nov 2022 11:32:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230072AbiKBLcz (ORCPT ); Wed, 2 Nov 2022 07:32:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229493AbiKBLcw (ORCPT ); Wed, 2 Nov 2022 07:32:52 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B9F224966 for ; Wed, 2 Nov 2022 04:32:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1CC92B82191 for ; Wed, 2 Nov 2022 11:32:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F11EC433C1; Wed, 2 Nov 2022 11:32:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667388768; bh=yoHsM6tzdVUYkSoFF8KSjoXXJcut+N1ohrZ0gOth29Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MmSYfK+Uxc8Af0fr9SSp1F2vFXBAAiNMWRKCQsYuYy1waaPZCBtnUFINCX7N3SM4W s13tuFdamtC6JI4h3QBVAqdxWZrQPJfB8CVyG1XTgKfIfYMA55jI/oXhGvlMPPMEXF B6TcVEnxrF900DtBvHOfSn6JMuqjvOoP+qd20yU2qEFmalPHp6h8dd26vEQHB9hKXE H+rNXTtKpSRZeNKTWEvimkPYEZe+vpc5qop5CQtfVbgwG0GfK/+RokTZYxTJ79fVQh SJiOnMArcxS6O5OsTgtDqtt8ss+/ovo0r5ongKtQ612I6Q3WROm26opwe4bKWmXdwl UwwPsJEWDKkJQ== Date: Wed, 2 Nov 2022 11:32:42 +0000 From: Mark Brown To: Venkata Prasad Potturu Cc: Venkata Prasad Potturu , alsa-devel@alsa-project.org, vsujithkumar.reddy@amd.com, Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com, ssabakar@amd.com, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Ajit Kumar Pandey , Akihiko Odaki , ye xingchen , open list Subject: Re: [PATCH] CHROMIUM: ASoC: amd: acp: Add tdm support for codecs in machine driver Message-ID: References: <20221028103443.30375-1-venkataprasad.potturu@amd.corp-partner.google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6S2eJXa8E4+Y1UCq" Content-Disposition: inline In-Reply-To: X-Cookie: Now, let's SEND OUT for QUICHE!! Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6S2eJXa8E4+Y1UCq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 02, 2022 at 10:59:07AM +0530, Venkata Prasad Potturu wrote: > On 11/1/22 20:01, Mark Brown wrote: > > On Tue, Nov 01, 2022 at 03:15:08PM +0530, Venkata Prasad Potturu wrote: > > Right, that's what the code does but why is this something that should > > be controlled in this fashion? > This machine driver is common for TDM mode and I2S mode, user can select TDM > mode or I2S mode. Why would the user choose one value or the other, and why would this choice be something that only changes at module load time? If this is user controllable I'd really expect it to be runtime controllable. You're not explaining why this is a module parameter. --6S2eJXa8E4+Y1UCq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmNiVVkACgkQJNaLcl1U h9BonQf/WOzgZDEZv8RNQ4jP23/wuknKo8guxsWKck2+1KjS6H71fYA8QQov0Ram ctytaYT07gWmnwqOU7rNk8dOsMLeqSi4fRaOrX9P5D2QJ8Q6HF7IgBHN4b9QMqLe /SuNdWvkY+rgkiaZOuMzXAw4xVXao0B1TG3feHqgeYeO3h4Gkozy6n2tQOn/ETBg N6szVTLGRqzGQeb12XBkpJmeQwUrA3VagVeV6CQquMUdnf4Q9xAsPi9LWYVpS73U lh4digzscLLrlU/yZxbqz4gJqrZ+iGbQRBa2cD16pDueAIuDBtSh9Dx+k95Y0MvS VY5i0Qe/maNcCPV4537jKuwcMxlkLA== =DdXj -----END PGP SIGNATURE----- --6S2eJXa8E4+Y1UCq--