From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E09BBC433FE for ; Thu, 3 Nov 2022 09:48:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231130AbiKCJsB (ORCPT ); Thu, 3 Nov 2022 05:48:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbiKCJrz (ORCPT ); Thu, 3 Nov 2022 05:47:55 -0400 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3C81E000 for ; Thu, 3 Nov 2022 02:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1667468857; bh=mAFMlhBrnqdkVI9PXuWkqqbxF2DjPNvJ9IhFJvqdOVo=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=h4Wz34UUxeJ8s6rpH8sXT0f8pKWEYqcefmbzOxGTIO9ZCZgidDnRjnJVXuialwvU5 2ayvNwhCJXYC4P6SYsMMoqMxJPKTk8zA1jEgyf7OWhZlIkc9/fOl9uBv14c8vleJWl 0NUL7GZ4bJqolqJUId8r2OCTH0cagdv57wXgIRLU= Received: by b-2.in.mailobj.net [192.168.90.12] with ESMTP via [213.182.55.206] Thu, 3 Nov 2022 10:47:36 +0100 (CET) X-EA-Auth: yTdpYMwEK5LwbRoruVtM0kM+WYm0pxaNZg8ri2b78h6/fZ/bX61SRRGztsAWjrODKklY4rIOgKodwmq59mpdNramcbircz2G Date: Thu, 3 Nov 2022 15:17:31 +0530 From: Deepak R Varma To: Philipp Hortmann Cc: outreachy@lists.linux.dev, Larry Finger , Phillip Potter , Pavel Skripkin , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: r8188eu: remove unused struct declarations Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 02, 2022 at 11:09:46PM +0100, Philipp Hortmann wrote: > On 11/2/22 21:53, Deepak R Varma wrote: > > Some structures are only declared but have not been used anywhere > > in the code. Remove such unused structs. Issue identified as part > > of coccicheck report driven code investigation. > > > > Tested-by: Philipp Hortmann # Edimax N150 Hello Philipp, Thank you for testing the changes. Request (not urgent): Can you please help me understand how do you test such changes? Do we need specific hardware for functional tests? Is there a documentation available to know more about the testing? I am interested in attaching a physical device to my machine and be able to debug and test the changes. Can you please provide details when you have time? Thank you in advance! ./drv >