On Wed, Nov 02, 2022 at 10:29:58PM +0000, Joel Stanley wrote:
> On Tue, 1 Nov 2022 at 11:22, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote:
> >
> > This defconfig aims to offer a reasonable set of defaults for all
> > systems running on a Nuvoton WPCM450 chip.
> 
> I was going to ask if we could instead have a common nuvoton
> defconfig, but this is an ARMv5 part so we can't also select the ARMv7
> npcm750.

Correct.

> 
> Reviewed-by: Joel Stanley <joel@jms.id.au>
> 


> > +CONFIG_ARM_APPENDED_DTB=y
> 
> Do you use this? OpenBMC systems tend to just use FIT, so we don't
> need this option.

I use this, because there is no modern U-Boot port for WPCM450 yet
(as far as I'm aware).

> > +CONFIG_KEXEC=y

I also use kexec, it's useful during development, but I see that it's
not so useful for the BMC usecase.

> > +CONFIG_CPU_FREQ=y
> 
> Does the wpcm do frequency scaling? If not you could disable this.

No, as it currently stands the clock driver is read-only except for the
clock gates, and there is no cpufreq. I'll disable this option.

CPU_IDLE could plausibly be implemented on WPCM450, but currently isn't.


Thanks,
Jonathan