From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7FDAC433FE for ; Fri, 4 Nov 2022 09:09:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230507AbiKDJJR (ORCPT ); Fri, 4 Nov 2022 05:09:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229728AbiKDJJM (ORCPT ); Fri, 4 Nov 2022 05:09:12 -0400 Received: from formenos.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD2E095BA; Fri, 4 Nov 2022 02:09:09 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1oqsgV-00A1gl-5n; Fri, 04 Nov 2022 17:08:56 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 04 Nov 2022 17:08:55 +0800 Date: Fri, 4 Nov 2022 17:08:55 +0800 From: Herbert Xu To: liulongfang Cc: wangzhou1@hisilicon.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto/hisilicon: Add null judgment to the callback interface Message-ID: References: <20220930024320.29922-1-liulongfang@huawei.com> <717adf23-3080-5041-14ed-6ab5dcaddbf9@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 29, 2022 at 09:25:18AM +0800, liulongfang wrote: > > The context of the problem may not have been clearly stated in the previous > description. > > This is a problem found in one of our real user scenarios: > In this scenario of using an accelerator to perform encryption services, > it was originally intended to use the CPU to perform encryption services > in synchronous mode (without loading the hardware device driver, and without > registering the asynchronous callback function), but due to a deployment > error, the Hisi hardware device driver was loaded into the system, > this wrong operation causes the encryption service to call the device > driver of the hisi hardware, but the hardware device driver executes the > asynchronous mode, so the callback interface is called after the service > is completed. > This leads to this system calltrace problem. > > The purpose of this patch is to ensure that the device does not appear > calltrace in this abnormal situation. I'm still having trouble understanding this. Please give an exact call-trace that triggers the callback with a NULL callback pointer. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt