From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16D12C433FE for ; Fri, 4 Nov 2022 22:14:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229826AbiKDWO3 (ORCPT ); Fri, 4 Nov 2022 18:14:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbiKDWO1 (ORCPT ); Fri, 4 Nov 2022 18:14:27 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F011429B8; Fri, 4 Nov 2022 15:14:26 -0700 (PDT) Received: from zn.tnic (p200300ea9733e7a4329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e7a4:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A8D821EC02DD; Fri, 4 Nov 2022 23:14:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1667600064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=ecezFjV64/LD06J6jguRRXZl22Q3tcFx+db0PLVvgdI=; b=qJ9EzN5E1tRwW+/5g4DykyP+6H7FDc8rEd4+5XkwNMX7Ge9cskSIhebAZcuEXBsFPSDrdZ V2+9hv+kpnXecyKREX149KhAAmic9mpikaoE5CatmsWroS8HFQ47mbqeWFvVYRSjzfI15A BYJrMhT38FkgH3McnP3Qaa5HQHZz1A4= Date: Fri, 4 Nov 2022 23:14:24 +0100 From: Borislav Petkov To: "Joseph, Jithu" Cc: hdegoede@redhat.com, markgross@kernel.org, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, gregkh@linuxfoundation.org, ashok.raj@intel.com, tony.luck@intel.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, patches@lists.linux.dev, ravi.v.shankar@intel.com, thiago.macieira@intel.com, athenas.jimenez.gonzalez@intel.com Subject: Re: [PATCH 07/14] x86/microcode/intel: Expose microcode_sanity_check() Message-ID: References: <20221021203413.1220137-1-jithu.joseph@intel.com> <20221021203413.1220137-8-jithu.joseph@intel.com> <4ee6073a-461e-562d-5c00-d1b371288b63@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4ee6073a-461e-562d-5c00-d1b371288b63@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 04, 2022 at 03:02:42PM -0700, Joseph, Jithu wrote: > Wanted to check with you, if it is okay to rename the first "reserved" > field in microcode_header_intel to "metasize" today (as shown in the > diff below) or would you prefer to do that too at a later point ? > (doing so today will help to avoid redefining an IFS specific header > struct, with this as the only change ) No objections - it is not used by the microcode loader anyway. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette