From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Janne Grunau <j@jannau.net>
Cc: linux-usb@vger.kernel.org, Sven Peter <sven@svenpeter.de>,
stable@kernel.org, Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] usb: dwc3: Do not get extcon device when usb-role-switch is used
Date: Mon, 7 Nov 2022 13:25:54 +0200 [thread overview]
Message-ID: <Y2jrQgj53z/mhHmm@smile.fi.intel.com> (raw)
In-Reply-To: <20221106214804.2814-1-j@jannau.net>
On Sun, Nov 06, 2022 at 10:48:04PM +0100, Janne Grunau wrote:
> The change breaks device tree based platforms with PHY device and use
> usb-role-switch instead of an extcon switch. extcon_find_edev_by_node()
> will return EPROBE_DEFER if it can not find a device so probing without
> an extcon device will be deferred indefinitely. Fix this by
> explicitly checking for usb-role-switch.
> At least the out-of-tree USB3 support on Apple silicon based platforms
> using dwc3 with tipd USB Type-C and PD controller is affected by this
> issue.
We don't care about out-of-tree modules, do we?
OTOH, the problem you are trying to workaround is probably in a (mis)use of
deferred probe somewhere.
Btw, does it prevent the system boot or you just see the extcon in the list of
deferred devices after booting?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-07 11:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-06 21:48 Janne Grunau
2022-11-07 11:25 ` Andy Shevchenko [this message]
2022-11-07 16:00 ` Sven Peter
2022-11-08 2:02 ` Thinh Nguyen
2022-11-08 15:43 ` Greg Kroah-Hartman
2022-11-08 17:54 ` Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2jrQgj53z/mhHmm@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=andrew.smirnov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=j@jannau.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@kernel.org \
--cc=sven@svenpeter.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®