Re: [PATCH 2/4] serial: 8250_lpss: Configure DMA also w/o DMA filter

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Mon, Nov 07, 2022 at 01:07:06PM +0200, Ilpo Järvinen wrote:
> If the platform doesn't use DMA device filter (as is the case with
> Elkhart Lake), whole lpss8250_dma_setup() setup is skipped. This
> results in skipping also *_maxburst setup which is undesirable.
> Refactor lpss8250_dma_setup() to configure DMA even if filter is not
> setup.

...


> +	if (!lpss->dma_param.dma_dev) {
> +		dma = port->dma;
> +		goto confonly;

Perhaps

		if (dma)
			goto out_configuration_only;

		return 0;

(note the label naming as well).

> +	}

...

> +confonly:

> +	if (dma) {

But you know that previous code has dma != NULL. See above.

> +		dma->rxconf.src_maxburst = lpss->dma_maxburst;
> +		dma->txconf.dst_maxburst = lpss->dma_maxburst;
> +	}

-- 
With Best Regards,
Andy Shevchenko