From: Mark Brown <broonie@kernel.org>
To: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>
Cc: Venkata Prasad Potturu
<venkataprasad.potturu@amd.corp-partner.google.com>,
alsa-devel@alsa-project.org, vsujithkumar.reddy@amd.com,
Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
Sunil-kumar.Dommati@amd.com, ssabakar@amd.com,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>,
Akihiko Odaki <akihiko.odaki@gmail.com>,
ye xingchen <ye.xingchen@zte.com.cn>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] CHROMIUM: ASoC: amd: acp: Add tdm support for codecs in machine driver
Date: Mon, 7 Nov 2022 15:01:22 +0000 [thread overview]
Message-ID: <Y2kdwms39CQUMQp/@sirena.org.uk> (raw)
In-Reply-To: <7b97682d-5cf1-8be1-9c62-41c9fbd89018@amd.com>
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
On Mon, Nov 07, 2022 at 04:04:40PM +0530, Venkata Prasad Potturu wrote:
> On 11/2/22 17:02, Mark Brown wrote:
> > Why would the user choose one value or the other, and why would this
> > choice be something that only changes at module load time? If this is
> > user controllable I'd really expect it to be runtime controllable.
> > You're not explaining why this is a module parameter.
> Different vendors/OEM's use the same hardware as one need I2S mode and other
> need TDM mode, using common driver to support I2S and TDM mode with this
> parameter.
If a given board needs a specific configuration we should be configuring
based on identifying the board, not hoping that the user somehow knows
that this configuration is required and can work out how to do it. If
this is purely a software setting depending on the software stack
running on the device then it should be selected at runtime by that
software as part of the use case management.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-11-07 15:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 10:34 Venkata Prasad Potturu
2022-10-28 10:58 ` Mark Brown
[not found] ` <b384e012-31c5-8412-8b05-cd026c5d6a0f@amd.com>
2022-11-01 14:31 ` Mark Brown
[not found] ` <ca006546-9b0c-34df-2a33-a4f10b68f815@amd.com>
2022-11-02 11:32 ` Mark Brown
[not found] ` <7b97682d-5cf1-8be1-9c62-41c9fbd89018@amd.com>
2022-11-07 14:14 ` Pierre-Louis Bossart
2022-11-07 15:02 ` Venkata Prasad Potturu
2022-11-07 15:04 ` Pierre-Louis Bossart
2022-11-09 16:19 ` Venkata Prasad Potturu
2022-11-07 15:01 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2kdwms39CQUMQp/@sirena.org.uk \
--to=broonie@kernel.org \
--cc=AjitKumar.Pandey@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=akihiko.odaki@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ssabakar@amd.com \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
--cc=venkataprasad.potturu@amd.corp-partner.google.com \
--cc=vsujithkumar.reddy@amd.com \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®