From: Yury Norov <yury.norov@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Valentin Schneider <vschneid@redhat.com>,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Paul E . McKenney" <paulmck@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>,
Dmitry Vyukov <dvyukov@google.com>,
Sander Vanheule <sander@svanheule.net>,
Alexey Klimov <klimov.linux@gmail.com>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH v2] cpumask: limit visibility of FORCE_NR_CPUS
Date: Mon, 7 Nov 2022 10:20:43 -0800 [thread overview]
Message-ID: <Y2lMe/1sIKvxvuKf@yury-laptop> (raw)
In-Reply-To: <CAHk-=wjSVUpjh0UZW+w0C633gQo=-JhGH9ja8kUmRW0TUcSMpw@mail.gmail.com>
On Mon, Nov 07, 2022 at 09:55:34AM -0800, Linus Torvalds wrote:
> On Mon, Nov 7, 2022 at 4:45 AM Valentin Schneider <vschneid@redhat.com> wrote:
> >
> > True, this would have been neater as a single config, but AIUI it's a
> > required "trick" for allyesconfig. I would have expected other configs to
> > have hit similar issues in the past, but didn't find any.
>
> Actually, the standard trick for allmodconfig and allyesconfig is to
> use the "COMPILE_TEST" config variable.
>
> It's basically a variable for "I'm not going to *run* the result, but
> I want to make sure to get build coverage".
>
> And both allmodconfig and allyesconfig set that config option.
>
> In most cases, the "COMPILE_TEST" config variable is used to enable
> things that wouldn't make sense on the chosen hardware platform, so
> you have things like
>
> depends on ARCH_DAVINCI || COMPILE_TEST
>
> because some driver only makes sense on ARCH_DAVINCI, but people still
> want the build coverage.
>
> But sometimes it's used the other way around, so fro example on x86 we have
>
> config X86_DECODER_SELFTEST
>
> which explicitly depends on COMPILE_TEST *not* being set, because it's
> a test that takes forever to run (particularly for huge kernels), and
> so it's actually disabled for the common all{yes,mod}config cases.
>
> Same goes for things like LTO_CLANG_FULL. It's just expensive for big
> build tests, plus causes too many issues for now.
>
> End result: if some option actually *reduces* test coverage, or has
> some other reason why it makes no sense for build tests, use that
>
> depends on !COMPILE_TEST
>
> to not have allmodconfig and allyesconfig pick it.
Thanks, I'll send v3 than.
Thanks,
Yury
prev parent reply other threads:[~2022-11-07 18:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 22:59 Yury Norov
2022-11-04 17:43 ` Valentin Schneider
2022-11-04 22:36 ` Yury Norov
2022-11-07 12:45 ` Valentin Schneider
2022-11-07 17:55 ` Linus Torvalds
2022-11-07 18:20 ` Yury Norov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2lMe/1sIKvxvuKf@yury-laptop \
--to=yury.norov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dvyukov@google.com \
--cc=ebiggers@google.com \
--cc=geert@linux-m68k.org \
--cc=klimov.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=sander@svanheule.net \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®