From: Greg KH <gregkh@linuxfoundation.org>
To: Zheng Wang <zyytlz.wz@163.com>
Cc: zhengyejian1@huawei.com, dimitri.sivanich@hpe.com, arnd@arndb.de,
linux-kernel@vger.kernel.org, hackerzheng666@gmail.com,
alex000young@gmail.com, security@kernel.org, sivanich@hpe.com,
lkp@intel.com
Subject: Re: [PATCH v7] misc: sgi-gru: fix use-after-free error in gru_set_context_option, gru_fault and gru_handle_user_call_os
Date: Wed, 9 Nov 2022 11:08:19 +0100 [thread overview]
Message-ID: <Y2t8E597OQ8nk4D1@kroah.com> (raw)
In-Reply-To: <20221109093347.228761-1-zyytlz.wz@163.com>
On Wed, Nov 09, 2022 at 05:33:47PM +0800, Zheng Wang wrote:
> Gts may be freed in gru_check_chiplet_assignment.
> The caller still use it after that, UAF happens.
>
> Fix it by introducing a return value to see if it's in error path or not.
> Free the gts in caller if gru_check_chiplet_assignment check failed.
>
> Fixes: 55484c45dbec ("gru: allow users to specify gru chiplet 2")
> Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
> Acked-by: Dimitri Sivanich <sivanich@hpe.com>
> Tested-by: kernel test robot <lkp@intel.com>
The kernel robot did not provide a tested-by comment for this as they
did not test it.
Please never add tags that the person does not submit to you.
greg k-h
next prev parent reply other threads:[~2022-11-09 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 9:33 Zheng Wang
2022-11-09 10:08 ` Greg KH [this message]
2022-11-09 10:49 ` Zheng Hacker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2t8E597OQ8nk4D1@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alex000young@gmail.com \
--cc=arnd@arndb.de \
--cc=dimitri.sivanich@hpe.com \
--cc=hackerzheng666@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=security@kernel.org \
--cc=sivanich@hpe.com \
--cc=zhengyejian1@huawei.com \
--cc=zyytlz.wz@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®