From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CE90C4332F for ; Wed, 9 Nov 2022 11:27:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229666AbiKIL05 (ORCPT ); Wed, 9 Nov 2022 06:26:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229573AbiKIL0v (ORCPT ); Wed, 9 Nov 2022 06:26:51 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06C882AC57; Wed, 9 Nov 2022 03:26:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667993210; x=1699529210; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=E8fR1PP3piRuXUs8iAY6HPxHQkMepQgMDmtZV4slwnA=; b=PzNdbzNXngAzhdtYhra5RD3hGu74VlNK7sEhxFrYjDCvLfZnwmb8VPZt zreq6tCGXSOctiPud1hgC+KbG8/OXrc3Iij7YZeydIX6A8ZFrfHyDundE mgu2spCeSeP/WOogSknT20oZzWSZc9I5F8clvW0+9IwHe6xFWFegYXyPp 1MMPRTTIIF4YAPMX+ctSW5P0aiOg4ZkDdSdAIZbyTeE5HRQI24fWQo5hu R1NLpIJfiHpV0TaraaChtZG0RamUuDEogUYRFYZHUpxToS4yn7WhoNmsK ENUCS2vSiyNGbIU79yA+mVFCW8LgKUBmz7VuXZ80rCMYJ5nKYyTt1ZKwW w==; X-IronPort-AV: E=McAfee;i="6500,9779,10525"; a="290670409" X-IronPort-AV: E=Sophos;i="5.96,150,1665471600"; d="scan'208";a="290670409" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2022 03:26:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10525"; a="965959344" X-IronPort-AV: E=Sophos;i="5.96,150,1665471600"; d="scan'208";a="965959344" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP; 09 Nov 2022 03:26:48 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1osjEF-009iXF-17; Wed, 09 Nov 2022 13:26:47 +0200 Date: Wed, 9 Nov 2022 13:26:47 +0200 From: Andy Shevchenko To: "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH v1 1/2] resource: Replace printk(KERN_WARNING) by pr_warn() Message-ID: References: <20221109105114.32886-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 09, 2022 at 12:12:03PM +0100, Rafael J. Wysocki wrote: > On Wed, Nov 9, 2022 at 11:51 AM Andy Shevchenko > wrote: > > > > Replace printk(KERN_WARNING) by pr_warn(). > > > > While at it, use %pa for the resource_size_t variables. > > > > Signed-off-by: Andy Shevchenko > > This is Greg's stuff I think. OK. ... > > + resource_size_t end = addr + size - 1; > > And this change could be mentioned in the changelog too. And it's (indirectly). This is to have a variable to be consistent in the print. But I can add more explicit mention. Thank you for a review! -- With Best Regards, Andy Shevchenko