From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F24EC433FE for ; Thu, 10 Nov 2022 03:56:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232386AbiKJD4N (ORCPT ); Wed, 9 Nov 2022 22:56:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbiKJD4L (ORCPT ); Wed, 9 Nov 2022 22:56:11 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16A3E13CC3; Wed, 9 Nov 2022 19:56:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=R9bwS/U7S7bV0/7KYScNF9R6LQoDUoxJzxINgcOLK3k=; b=rnziAupdKaVrSkWJdztAWl3t29 Yn19OB1/8PTpNZ/bs8YIMaxByQ+8jW2da9eMRRirQjgNjNIgBGJcfnRSQFvsXJN11QtKZntOn9dlH voRh7kroEOSX/g3g8bLI4ua2IPnZP8Y9mPfXJdb32RFsKBHA6P6WArARMYYOSCvnixMG2IMyVmZcQ BPY9bWS942C1Z1bk1h/3pr/m/oEsJZTKFh5diJbCCGhTnef3vLnITDxnkJ3qpS0OSZXAIbsbM43Za hmTi6/MohzoksbTMyq2t4at/xo8d+ycHXTAPBmVRfcK2vmVPdpmJ404ve/+bPo5eyZexRlUmsAANr 234IM3Pg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1osyff-002RfX-Ga; Thu, 10 Nov 2022 03:56:07 +0000 Date: Wed, 9 Nov 2022 19:56:07 -0800 From: Luis Chamberlain To: Nick Alcock , Masahiro Yamada Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, akpm@linux-foundation.org, eugene.loh@oracle.com, kris.van.hees@oracle.com, mcgrof@kernel.org Subject: Re: [PATCH v9 1/8] kbuild: bring back tristate.conf Message-ID: References: <20221109134132.9052-1-nick.alcock@oracle.com> <20221109134132.9052-2-nick.alcock@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221109134132.9052-2-nick.alcock@oracle.com> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 09, 2022 at 01:41:25PM +0000, Nick Alcock wrote: > tristate.conf was dropped because it is not needed to build a > modules.builtin (although dropping it introduces a few false positives > into modules.builtin support), and doing so avoids one round of > recursion through the build tree to build it. But kallmodsyms support > requires building a mapping from object file name to built-in module > name for all builtin modules: this seems to me impossible to accomplish > without parsing all makefiles under the influence of tristate.conf, > since the makefiles are the only place this mapping is recorded. > > So bring it back for this purpose. (Thanks to the refactoring in > the 5.16 timeframe, this is basically a reimplementation of commit > 8b41fc4454e36fbfdbb23f940d023d4dece2de29 rather than a simple > reversion.) > > Signed-off-by: Nick Alcock > Reviewed-by: Victor Erminpour > Reviewed-by: Kris Van Hees I don't see the need, see the review of next patch. Luis