From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8633DC433FE for ; Thu, 24 Nov 2022 00:22:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229695AbiKXAWn (ORCPT ); Wed, 23 Nov 2022 19:22:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229604AbiKXAWj (ORCPT ); Wed, 23 Nov 2022 19:22:39 -0500 Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5B17193F4 for ; Wed, 23 Nov 2022 16:22:37 -0800 (PST) Received: by mail-qk1-x731.google.com with SMTP id k2so115098qkk.7 for ; Wed, 23 Nov 2022 16:22:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Nu3y1oldhrXGGz2CE0ALsd3V0V6fQ+XFV1XvQvd+KMs=; b=WkjX+6VBX5SNz1lYR27kfvaZwL5tyeJMjwuWHCxXs/VVzQmg+2hmBla07bAlzboOD+ Q7iWGBAv6XYVfhe2Y/pzT+/0SennWzJAYtMKUJEbqS5NaNkpSMOoOAQRefKxvVJuHVl4 v1h+S/cgjjxL2tKfcEP1ildeQqz0SYT2GJSSl1lCpBJiSnQZSoG381zaUgzbBOQgusQC wQU2pfW1xYTrwvuj6KvF2lTtDcogqx9YntPA5ivhqCU7aHt7g/5XgUZCBJPElamnVRGs +hn4i2Zq0moEyT536cCURtCSO0kkZQ2P//pS1MPKBIKQBww7UCWHOqlu/XAHrKKlHvpm ISzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Nu3y1oldhrXGGz2CE0ALsd3V0V6fQ+XFV1XvQvd+KMs=; b=a1R5HaNcgkWgVb7tPAgLpRjih5nxIX1vjaqvDjSymdxIboEQRktLFuLle7LDT2WGHS dDRP/UzmZfdKv090zePw18SkPC2kdhVc4ab1SWnH6VTZxbnH2ObeiqDRG7xINEpOSRNr DGJMYO8PKwrQvC3u6cDyQBVXQC/H5+CmZvWiqm3lrBHb0jzxPMlM8t618SV0L0ztgtfC 85Bivw4ooUZXZisZjjiSpmR0ldHu+XK++vbc9tozxvo4cJeQ3X3diBMJPE6WDskuYs8k hdl+waAdKmN98lJBzBTbyBYPbBJoUFV/qCtVJVC9b7E9V1ohe6hhZD/KaB/pUlleNYKN kNCw== X-Gm-Message-State: ANoB5plYBof1j49G3xHnKP01x6qUTpu5YgbyZkw7cZgzvuennmtIXKym yJyQVNpAy4wOkY/0T4uuAzkM0g== X-Google-Smtp-Source: AA0mqf7FO7iMH/gayxVExvVO7VRIeDKAdeX2kAYpzMWARz8tjTV2SgcnrNcNqKklVV0Olg/odoMjZw== X-Received: by 2002:a37:444b:0:b0:6e1:b888:bbf9 with SMTP id r72-20020a37444b000000b006e1b888bbf9mr26362956qka.680.1669249356807; Wed, 23 Nov 2022 16:22:36 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-47-55-122-23.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.122.23]) by smtp.gmail.com with ESMTPSA id j3-20020a05620a288300b006fc2cee4486sm1918240qkp.62.2022.11.23.16.22.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 16:22:35 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1oy00h-00BxJy-5K; Wed, 23 Nov 2022 20:22:35 -0400 Date: Wed, 23 Nov 2022 20:22:35 -0400 From: Jason Gunthorpe To: Guoqing Jiang , Bernard Metzler Cc: wangyufen , Dmitry Vyukov , syzbot , Leon Romanovsky , chenzhongjin@huawei.com, RDMA mailing list , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com, Zhu Yanjun , Bob Pearson Subject: Re: [syzbot] unregister_netdevice: waiting for DEV to become free (7) Message-ID: References: <00000000000060c7e305edbd296a@google.com> <2f54056f-0acf-e088-c6cc-9ffce77bbe24@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2f54056f-0acf-e088-c6cc-9ffce77bbe24@linux.dev> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 23, 2022 at 05:45:53PM +0800, Guoqing Jiang wrote: > But it is the caller's responsibility to destroy it since commit > dd37d2f59eb8. > > > The causes are as follows: > > > > rdma_listen() > >   rdma_bind_addr() > >     cma_acquire_dev_by_src_ip() > >       cma_attach_to_dev() > >         _cma_attach_to_dev() > >           cma_dev_get() > > Thanks for the analysis. > > And for the two callers of cma_listen_on_dev, looks they have > different behaviors with regard to handling failure. Yes, the CM is not the problem, and that print from it is unrelated I patched in netdevice_tracker and get this: [ 237.475070][ T7541] unregister_netdevice: waiting for vlan0 to become free. Usage count = 2 [ 237.477311][ T7541] leaked reference. [ 237.478378][ T7541] ib_device_set_netdev+0x266/0x730 [ 237.479848][ T7541] siw_newlink+0x4e0/0xfd0 [ 237.481100][ T7541] nldev_newlink+0x35c/0x5c0 [ 237.482121][ T7541] rdma_nl_rcv_msg+0x36d/0x690 [ 237.483312][ T7541] rdma_nl_rcv+0x2ee/0x430 [ 237.484483][ T7541] netlink_unicast+0x543/0x7f0 [ 237.485746][ T7541] netlink_sendmsg+0x918/0xe20 [ 237.486866][ T7541] sock_sendmsg+0xcf/0x120 [ 237.488006][ T7541] ____sys_sendmsg+0x70d/0x8b0 [ 237.489294][ T7541] ___sys_sendmsg+0x11d/0x1b0 [ 237.490404][ T7541] __sys_sendmsg+0xfa/0x1d0 [ 237.491451][ T7541] do_syscall_64+0x35/0xb0 [ 237.492566][ T7541] entry_SYSCALL_64_after_hwframe+0x63/0xcd Which seems to confirm my original prediction, except this is siw not rxe.. Maybe rxe was the wrong guess, or maybe it is troubled too in other reports? Jason