From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F878C43217 for ; Mon, 14 Nov 2022 21:16:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237527AbiKNVQ2 (ORCPT ); Mon, 14 Nov 2022 16:16:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235941AbiKNVQ0 (ORCPT ); Mon, 14 Nov 2022 16:16:26 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5868555B2 for ; Mon, 14 Nov 2022 13:15:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668460528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xhFKsQdnuFAVM9AV+tj1zSx92ABSp3wva+haXFolNdk=; b=VpvZ0jnkIX4rWNr2OgfkRWv8XXgiZhzqJ7yMYutVl7sLwCtD+XbDrPuBySu8jTo2AeL8Vb TWSdVGd256ZLZGLKK1Khhqqi+pkHqdVKSrz/k5ISSueZbMUs+A13OQG9ghRMjPe8wQH4Fs kbLK5nic0EF5dsFu9Jr84Jj5vtQmFDk= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-634-RXkKBnZjPjuHzF7la2-PJQ-1; Mon, 14 Nov 2022 16:15:27 -0500 X-MC-Unique: RXkKBnZjPjuHzF7la2-PJQ-1 Received: by mail-qt1-f200.google.com with SMTP id s14-20020a05622a1a8e00b00397eacd9c1aso8947857qtc.21 for ; Mon, 14 Nov 2022 13:15:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xhFKsQdnuFAVM9AV+tj1zSx92ABSp3wva+haXFolNdk=; b=oWqWkY63gxyAsoA5pHFTpnvo8pdTsf4uh4e6DdAiDofgt8zDOyuZOegWsJQcIaDngQ wB5eXkSBaLgWigQDKqQFq/TKELQbmBvf4G/zmF1OlScCWO6VNyX06a/0CuRl1qJyZ6Ry 4dCRwEnaCjXgL8hwrbpmvSTbeO5KGvlQqoZa2mQpDAsfFnX/c0jGc0Qbpis6ANU0ukeS k+Bm1/t6KHpz2WXJFgAeeO2qxTR9kyZzG+cdo3Gsglm7aPFNj27aA17EgsVolH4g1BQu bKw+arjhq3TvqzsL2iOoB1C2NhhA42sPf+h3Ju7UiVaU1c5ZruLC7GDHhNFpvoapVIkq eyHQ== X-Gm-Message-State: ANoB5pmkwia+3eJlg5PRd3AFqph/3E09H2MpnwPIl/Xq0OljCVgYkjh5 KQhJfyptP0XzRHvLU8EYCe0DtiapQrfYHa5CRk2fU8TKy0grXOe/79x20FG+sICbqcKRlFlNHnt /37IJqvdnRN4vu0QT/LWPuQnu X-Received: by 2002:a37:7d8:0:b0:6ce:4418:16d6 with SMTP id 207-20020a3707d8000000b006ce441816d6mr12662811qkh.138.1668460526596; Mon, 14 Nov 2022 13:15:26 -0800 (PST) X-Google-Smtp-Source: AA0mqf4mG+Q84LW9nFJZrr65rugoziYiZImLqxLy1XSu8SHxKguFF1ZY+pQanMGDAPaMhpwD/6he+A== X-Received: by 2002:a37:7d8:0:b0:6ce:4418:16d6 with SMTP id 207-20020a3707d8000000b006ce441816d6mr12662797qkh.138.1668460526382; Mon, 14 Nov 2022 13:15:26 -0800 (PST) Received: from x1 (c-73-214-169-22.hsd1.pa.comcast.net. [73.214.169.22]) by smtp.gmail.com with ESMTPSA id h21-20020ac85155000000b003a50248b89esm6183769qtn.26.2022.11.14.13.15.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Nov 2022 13:15:26 -0800 (PST) Date: Mon, 14 Nov 2022 16:15:25 -0500 From: Brian Masney To: Thierry Reding Cc: Bartosz Golaszewski , Linus Walleij , Andy Shevchenko , Dmitry Torokhov , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski Subject: Re: [PATCH] gpiolib: of: Use correct fwnode for DT-probed chips Message-ID: References: <20221111113732.461881-1-thierry.reding@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221111113732.461881-1-thierry.reding@gmail.com> User-Agent: Mutt/2.2.7 (2022-08-07) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 11, 2022 at 12:37:32PM +0100, Thierry Reding wrote: > From: Thierry Reding > > The OF node store in chip->fwnode is used to explicitly override the FW > node for a GPIO chip. For chips that use the default FW node (i.e. that > of their parent device), this will be NULL and cause the chip not to be > fully registered. > > Instead, use the GPIO device's FW node, which is set to either the node > of the parent device or the explicit override in chip->fwnode. > > Fixes: 8afe82550240 ("gpiolib: of: Prepare of_gpiochip_add() / of_gpiochip_remove() for fwnode") > Tested-by: Marek Szyprowski > Signed-off-by: Thierry Reding Reviewed-by: Brian Masney Tested-by: Brian Masney I separately sent a similar type of patch to fix the same issue today: https://lore.kernel.org/linux-arm-msm/20221114202943.2389489-1-bmasney@redhat.com/T/#u I'm still not sure what caused this breakage in linux-next. Brian