From: Nathan Chancellor <nathan@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>,
Nicolas Schier <nicolas@fjasle.eu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: revive parallel execution for .tmp_initcalls.lds rule
Date: Mon, 14 Nov 2022 17:18:34 -0700 [thread overview]
Message-ID: <Y3La2mwCgD8r/5PI@dev-arch.thelio-3990X> (raw)
In-Reply-To: <20221114174617.211980-1-masahiroy@kernel.org>
On Tue, Nov 15, 2022 at 02:46:17AM +0900, Masahiro Yamada wrote:
> Prior to commit 5d45950dfbb1 ("kbuild: move vmlinux.o link to
> scripts/Makefile.vmlinux_o"), jobserver-exec was invoked from the shell
> script, link-vmlinux.sh. It can get access to the jobserver because
> Makefile adds '+' prefix, as in:
>
> +$(call if_changed_dep,link_vmlinux)
>
> Since 5d45950dfbb1, jobserver-exec is invoked from Makefile, but the
> '+' prefix is missing, hence jobserver-exec has no access to the
> jobserver.
>
> Fixes: 5d45950dfbb1 ("kbuild: move vmlinux.o link to scripts/Makefile.vmlinux_o")
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
At least it doesn't seem like compile times were majorly affected. I
benchmarked arm64 allmodconfig (worst case scenario with ThinLTO):
Benchmark 1: 094226ad94f4 ("Linux 6.1-rc5")
Time (mean ± σ): 899.036 s ± 1.133 s [User: 49314.495 s, System: 3840.796 s]
Range (min … max): 898.118 s … 900.302 s 3 runs
Benchmark 2: 0f45cbb5399b ("kbuild: revive parallel execution for .tmp_initcalls.lds rule")
Time (mean ± σ): 898.482 s ± 0.152 s [User: 49329.703 s, System: 3836.408 s]
Range (min … max): 898.306 s … 898.584 s 3 runs
Summary
'0f45cbb5399b ("kbuild: revive parallel execution for .tmp_initcalls.lds rule")' ran
1.00 ± 0.00 times faster than '094226ad94f4 ("Linux 6.1-rc5")'
> ---
>
> scripts/Makefile.vmlinux_o | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.vmlinux_o b/scripts/Makefile.vmlinux_o
> index 0edfdb40364b..ae52d3b3f063 100644
> --- a/scripts/Makefile.vmlinux_o
> +++ b/scripts/Makefile.vmlinux_o
> @@ -19,7 +19,7 @@ quiet_cmd_gen_initcalls_lds = GEN $@
>
> .tmp_initcalls.lds: $(srctree)/scripts/generate_initcall_order.pl \
> vmlinux.a $(KBUILD_VMLINUX_LIBS) FORCE
> - $(call if_changed,gen_initcalls_lds)
> + +$(call if_changed,gen_initcalls_lds)
>
> targets := .tmp_initcalls.lds
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-11-15 0:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 17:46 Masahiro Yamada
2022-11-14 21:13 ` Nicolas Schier
2022-11-15 0:18 ` Nathan Chancellor [this message]
2022-11-15 12:16 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3La2mwCgD8r/5PI@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®