From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23C4DC433FE for ; Tue, 15 Nov 2022 17:14:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231687AbiKOROy (ORCPT ); Tue, 15 Nov 2022 12:14:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229645AbiKOROs (ORCPT ); Tue, 15 Nov 2022 12:14:48 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB19220355; Tue, 15 Nov 2022 09:14:47 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7C6A961937; Tue, 15 Nov 2022 17:14:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74244C433D6; Tue, 15 Nov 2022 17:14:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668532486; bh=k9HdUS7zrOXlFLwjH2b7B5JgNY4XRW93USVSPBniQL8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g2wlCdRyIonCrx94ab53JsUvdKYuct2JFfM3qCI9beEtMpQxlLiPgCEBHq2ieuC2+ L+V/cgQtXo+8iyxseZzxWSyMOacARzHlm/NKZlXgeXE/2tNMho7iHQFVEb5yMBBkfa N7BVzCmDc3+VVOfEa+vMlIOCOI8eRHCAyGHw7tVV6rUJOC5vFOVNtvx3r4XgJS9wlE f59XtLHM7eXG3k2oRLQWbpyhJuBAcAoothg+LS7lWcUXkf1wZ+98o/gGeP9TBDzoVX EqCLu11OrmM4hSJL/NnYlJcJn6dxgi5Q+SCVruXfDVVA1H8XQgTaDXoQTPls/+ZEwc BAYFp1xre729w== Date: Tue, 15 Nov 2022 17:14:14 +0000 From: Mark Brown To: William Breathitt Gray Cc: linus.walleij@linaro.org, brgl@bgdev.pl, andriy.shevchenko@linux.intel.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, michael@walle.cc Subject: Re: [PATCH v2 2/4] regmap-irq: Add handle_mask_sync() callback Message-ID: References: <53e9e89cc9d7e9c20cbdfc13b360dcb43d07f832.1668129763.git.william.gray@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6WJY0q1LVzw+BIMY" Content-Disposition: inline In-Reply-To: <53e9e89cc9d7e9c20cbdfc13b360dcb43d07f832.1668129763.git.william.gray@linaro.org> X-Cookie: Ego sum ens omnipotens. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6WJY0q1LVzw+BIMY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 10, 2022 at 08:55:51PM -0500, William Breathitt Gray wrote: > Provide a public callback handle_mask_sync() that drivers can use when > they have more complex IRQ masking logic. The default implementation is > regmap_irq_handle_mask_sync(), used if the chip doesn't provide its own > callback. Can you provide examples of something that would make sense to open code in a driver rather than factoring out? It looks like this has been added due to one of the devices you're looking at for some reason disabling it's upstream interrupt when all of the downstream interrupts are masked, while weird that doesn't seem especally device specific. --6WJY0q1LVzw+BIMY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmNzyOYACgkQJNaLcl1U h9DI5wf/ReemeRWA1bhQND00SnN8oMnU5R0oinaAM9yFZymGxqvEVbBf8kf5wcCV N8HjYk9DASKbW9kU/n7g3KbTt9f88bXcniJTKdSaDl8IaunGHgc9n/lpZuhkZmhT UaMfu9YmHqc83Qle9cixfbc49kP2j5pfS8gLwkUd6PShZflYfg8P6RxVpb7SoI73 qCPhdx9Q2WvNLW4jmSxyqC/VuYUV7iU8AC2bQ33TpkC46F1NM9+HdSLBoM5pHap4 GEFOxh+/6hmYGZiVK8D2HD6Bbjy9xWGZyhNdZm7kVsifUlnUp0cE+aehsZX0CrBf CCwLm4KtyjwBZjY/m2U1YNl0Sbzezw== =dw0O -----END PGP SIGNATURE----- --6WJY0q1LVzw+BIMY--