From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3505C433FE for ; Tue, 15 Nov 2022 19:58:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230163AbiKOT6q (ORCPT ); Tue, 15 Nov 2022 14:58:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229797AbiKOT6m (ORCPT ); Tue, 15 Nov 2022 14:58:42 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6EC914D02; Tue, 15 Nov 2022 11:58:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wkNdwJHAKziEE6309xkOYMnvNT11EPNoY/CfaDzZEx4=; b=A/zsdlcRdbGflGctZ6U83MWyLM CBV9ZvMwwqcYScp5HfiWV1wiVGzPDX9hLnreiZcxCt9qz58biGaFN/UKF3Xhz56rjhVqOBP5dgQMv ROo03/OCvwAeCovCLAuRYA/xqaWuP95Qw4ldGN86gK2p6s5lVgTUFA6uCfigV8qphtyrYPa8x3TVr XUKDCHgFb7uDIXhrZPR6ZUz85TVsiyEd3B4up3QluudIIiHnTLtF507YBbEI/jo7hdPWOFyJuS89g KSArmkZoy2OLhskcW1tbh97iLfmMy9nYc2yWxuePr2Rpny+b07U7B8Une1luNqoYQsQsQQSEkUntY P7LY1j+A==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ov24o-00ESak-2L; Tue, 15 Nov 2022 19:58:34 +0000 Date: Tue, 15 Nov 2022 11:58:34 -0800 From: Luis Chamberlain To: Nick Alcock Cc: "Leizhen (ThunderTown)" , masahiroy@kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, akpm@linux-foundation.org, eugene.loh@oracle.com, kris.van.hees@oracle.com, Steven Rostedt Subject: Re: [PATCH v9 4/8] kallsyms: introduce sections needed to map symbols to built-in modules Message-ID: References: <20221109134132.9052-1-nick.alcock@oracle.com> <20221109134132.9052-5-nick.alcock@oracle.com> <87mt8tv554.fsf@esperi.org.uk> <76d7ba29-c7d2-d082-5928-599844112494@huawei.com> <87edu4uz7z.fsf@esperi.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87edu4uz7z.fsf@esperi.org.uk> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 15, 2022 at 01:25:04PM +0000, Nick Alcock wrote: > (I'm also a bit miffed because people are worrying about 10K of > overhead at the same time as a patch is going in adding half a meg ;) You are missing that the reason why your patch lacks much traction is it lacks a clear *use* case. It has nothing to do with space. The cover letter can be really summarized in a condensed way to get the point accross to just include the text on your first paragraph you had at Plumbers: https://lpc.events/event/16/contributions/1379/ This gets the point accross well. The rest of the cover letter is just pure noise and gets me lost. But for instance, when I reviewed the patch for adding ranges, your cover letter describes the *justification*, the *why* to do that, but the patch does not at all. Please make sure that your commits describe *why* clearly. Please get a bit of help from your team to condense to the cover letter to only include what is needed if someone is reading the patchset for the very first time. And then users.. we need users clearly documented, who the heck is using this or wants this / is going to use it and why. Luis