From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A4F5AC43217
	for <linux-kernel@archiver.kernel.org>; Wed, 16 Nov 2022 01:11:10 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231675AbiKPBLI (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 15 Nov 2022 20:11:08 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44958 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231668AbiKPBLF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 15 Nov 2022 20:11:05 -0500
Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FFF83204D
        for <linux-kernel@vger.kernel.org>; Tue, 15 Nov 2022 17:11:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:
        Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:
        Content-ID:Content-Description:Content-Disposition:In-Reply-To:References;
        bh=igE9pR8KJP0rmfT2DzY+yNgVlyIc3YQ40GsBbREq18M=; b=57FCF52a/FBGnGVQROymvO8put
        wrznBZmQgWdl5WUTjG24FAHGW8Ht60cZCO8wEiMzMAn8i4pu6OyI5kLY56Zs1xAmOIyjaPrwflvrq
        axcVdMdywu/sIUK4iy2/1gQZRIAzGSNHzTabV2xgMKdkMGcH28mSTM423rjK407UvE3M=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2)
        (envelope-from <andrew@lunn.ch>)
        id 1ov6wf-002W1k-Nd; Wed, 16 Nov 2022 02:10:29 +0100
Date:   Wed, 16 Nov 2022 02:10:29 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     Gregory Clement <gregory.clement@bootlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: mvebu: switch to using gpiod API in pm-board code
Message-ID: <Y3Q4hVn3GEOm4nMq@lunn.ch>
References: <Y3Qc6et/d+vhd71Q@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y3Qc6et/d+vhd71Q@google.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -		ret = gpio_direction_output(pic_gpios[i], 0);
> -		if (ret < 0) {
> -			gpio_free(pic_gpios[i]);
> +		pic_gpios[i] = fwnode_gpiod_get_index(of_fwnode_handle(np),
> +						      "ctrl", i, GPIOD_OUT_HIGH,
> +						      name);

The old code passes value=0 to gpio_direction_output(). For
fwnode_gpiod_get_index() you pass GPIOD_OUT_HIGH. Is this correct?

	Andrew