mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aaron Lu <aaron.lu@intel.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Joel Fernandes <joel@joelfernandes.org>, <mingo@redhat.com>,
	<peterz@infradead.org>, <juri.lelli@redhat.com>,
	<dietmar.eggemann@arm.com>, <rostedt@goodmis.org>,
	<bsegall@google.com>, <mgorman@suse.de>, <bristot@redhat.com>,
	<vschneid@redhat.com>, <linux-kernel@vger.kernel.org>,
	<parth@linux.ibm.com>, <qyousef@layalina.io>,
	<chris.hyser@oracle.com>, <patrick.bellasi@matbug.net>,
	<David.Laight@aculab.com>, <pjt@google.com>, <pavel@ucw.cz>,
	<tj@kernel.org>, <qperret@google.com>,
	<tim.c.chen@linux.intel.com>, <joshdon@google.com>,
	<timj@gnu.org>, <kprateek.nayak@amd.com>, <yu.c.chen@intel.com>,
	<youssefesmat@chromium.org>, <riel@redhat.com>
Subject: Re: [PATCH v8 1/9] sched/fair: fix unfairness at wakeup
Date: Wed, 16 Nov 2022 16:25:33 +0800	[thread overview]
Message-ID: <Y3SefaraLvX2hPYj@ziqianlu-desk2> (raw)
In-Reply-To: <CAKfTPtD2A3QaMON_jkhaobY0Wy+LpnAnfhtuaozK_OkmSvuf8Q@mail.gmail.com>

On Mon, Nov 14, 2022 at 12:05:18PM +0100, Vincent Guittot wrote:
> On Mon, 14 Nov 2022 at 04:06, Joel Fernandes <joel@joelfernandes.org> wrote:
> >
> > Hi Vincent,
> >
> > On Thu, Nov 10, 2022 at 06:50:01PM +0100, Vincent Guittot wrote:

... ...

> > > +static inline unsigned long  get_latency_max(void)
> > > +{
> > > +     unsigned long thresh = get_sched_latency(false);
> > > +
> > > +     thresh -= sysctl_sched_min_granularity;
> >
> > Could you clarify, why are you subtracting sched_min_granularity here? Could
> > you add some comments here to make it clear?
> 
> If the waking task failed to preempt current it could to wait up to
> sysctl_sched_min_granularity before preempting it during next tick.

check_preempt_tick() compares vdiff/delta between the leftmost se and
curr against curr's ideal_runtime, it doesn't use thresh here or the
adjusted wakeup_gran, so I don't see why reducing thresh here can help
se to preempt curr during next tick if it failed to preempt curr in its
wakeup path.

I can see reducing thresh here with whatever value can help the waking
se to preempt curr in wakeup_preempt_entity() though, because most
likely the waking se's vruntime is cfs_rq->min_vruntime -
sysctl_sched_latency/2 and curr->vruntime is near cfs_rq->min_vruntime
so vdiff is about sysctl_sched_latency/2, which is the same value as
get_sched_latency(false) and when thresh is reduced some bit, then vdiff
in wakeup_preempt_entity() will be larger than gran and make it possible
to preempt.

So I'm confused by your comment or I might misread the code.

  parent reply	other threads:[~2022-11-16  8:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10 17:50 [PATCH v8 0/9] Add latency priority for CFS class Vincent Guittot
2022-11-10 17:50 ` [PATCH v8 1/9] sched/fair: fix unfairness at wakeup Vincent Guittot
2022-11-14  3:06   ` Joel Fernandes
2022-11-14 11:05     ` Vincent Guittot
2022-11-16  2:10       ` Joel Fernandes
2022-11-16  8:25       ` Aaron Lu [this message]
2022-11-17  9:18         ` Vincent Guittot
2022-11-14 16:19   ` Patrick Bellasi
2022-11-14 16:46     ` Vincent Guittot
2022-11-14 19:13   ` Dietmar Eggemann
2022-11-15  7:26     ` Vincent Guittot
2022-11-10 17:50 ` [PATCH v8 2/9] sched: Introduce latency-nice as a per-task attribute Vincent Guittot
2022-11-10 17:50 ` [PATCH v8 3/9] sched/core: Propagate parent task's latency requirements to the child task Vincent Guittot
2022-11-10 17:50 ` [PATCH v8 4/9] sched: Allow sched_{get,set}attr to change latency_nice of the task Vincent Guittot
2022-11-10 17:50 ` [PATCH v8 5/9] sched/fair: Take into account latency priority at wakeup Vincent Guittot
2022-11-14 16:20   ` Patrick Bellasi
2022-11-15 15:40     ` Vincent Guittot
2022-11-10 17:50 ` [PATCH v8 6/9] sched/fair: Add sched group latency support Vincent Guittot
2022-11-14 16:20   ` Patrick Bellasi
2022-11-14 16:57     ` Vincent Guittot
2022-11-10 17:50 ` [PATCH v8 7/9] sched/core: Support latency priority with sched core Vincent Guittot
2022-11-10 17:50 ` [PATCH v8 8/9] sched/fair: Add latency list Vincent Guittot
2022-11-10 17:50 ` [PATCH v8 9/9] sched/fair: remove check_preempt_from_others Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3SefaraLvX2hPYj@ziqianlu-desk2 \
    --to=aaron.lu@intel.com \
    --cc=David.Laight@aculab.com \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=chris.hyser@oracle.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=joel@joelfernandes.org \
    --cc=joshdon@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=parth@linux.ibm.com \
    --cc=patrick.bellasi@matbug.net \
    --cc=pavel@ucw.cz \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=qperret@google.com \
    --cc=qyousef@layalina.io \
    --cc=riel@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=tim.c.chen@linux.intel.com \
    --cc=timj@gnu.org \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=youssefesmat@chromium.org \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®