mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Hui Tang <tanghui20@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	mw@semihalf.com, linux@armlinux.org.uk, pabeni@redhat.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	yusongping@huawei.com
Subject: Re: [PATCH net v2] net: mdio-ipq4019: fix possible invalid pointer dereference
Date: Mon, 21 Nov 2022 15:36:46 +0100	[thread overview]
Message-ID: <Y3uM/qNkI8Cqiqr4@lunn.ch> (raw)
In-Reply-To: <3cb5a576-8eb7-54fc-4f4b-9db360b6713d@huawei.com>

> Hi, Andrew
> 
> My new patchset is ready, but I just found out that another patch has been
> applied to netdev/net.git. Can I solve the problem in present way? And I
> will add devm_ioremap_resource_optional() helper later to optimize related
> drivers. How about this?

This is one of those harder to merge changes. patches to lib/devres.c
generally go via GregKH. Networking changes are merged via the netdev
list.

Did you find this issue via a static analyser? I assume you are
running it over the entire tree and are finding problems in multiple
subsystems? So devm_ioremap_resource_optional() is potentially going
to be needed in lots of places?

One way to get this merged is to cross post the patch adding
devm_ioremap_resource_optional() and ask GregKH to ACK it, and then
get netdev to merge it. You can then use it within the netdev
subsystem. What you cannot do is use it in other subsystems until the
next kernel cycle when it will be globally available.

So three patches. One adding devm_ioremap_resource_optional(), one to
revert the 'fix', and one with the real fix using
devm_ioremap_resource_optional().

     Andrew

  reply	other threads:[~2022-11-21 14:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17  9:05 Hui Tang
2022-11-17 13:57 ` Andrew Lunn
2022-11-18  7:21   ` Hui Tang
2022-11-18 13:44     ` Andrew Lunn
2022-11-19  5:41       ` Hui Tang
2022-11-21 14:36         ` Andrew Lunn [this message]
2022-11-23  1:10           ` Hui Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3uM/qNkI8Cqiqr4@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mw@semihalf.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tanghui20@huawei.com \
    --cc=yusongping@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®