From: Tejun Heo <tj@kernel.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, rostedt@goodmis.org,
Uladzislau Rezki <urezki@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
Lai Jiangshan <jiangshanlai@gmail.com>
Subject: Re: [PATCH v2 rcu 13/16] workqueue: Make queue_rcu_work() use call_rcu_flush()
Date: Mon, 21 Nov 2022 15:37:56 -1000 [thread overview]
Message-ID: <Y3wn9AK1XxEZIIFw@slm.duckdns.org> (raw)
In-Reply-To: <20221122012357.GV4001@paulmck-ThinkPad-P17-Gen-1>
On Mon, Nov 21, 2022 at 05:23:57PM -0800, Paul E. McKenney wrote:
> On Mon, Nov 21, 2022 at 03:09:29PM -1000, Tejun Heo wrote:
> > On Mon, Nov 21, 2022 at 05:04:18PM -0800, Paul E. McKenney wrote:
> > > And another call_rcu() instance that cannot be lazy is the one
> > > in queue_rcu_work(), given that callers to queue_rcu_work() are
> > > not necessarily OK with long delays.
> >
> > So, this is fine but another thing we can do is propagating the distinction
> > through the workqueue interface so that the the choice can be made by
> > workqueue users. Would that make sense?
>
> It might well! My thought was to wait to suggest that until we found a
> real-life case where this was needed, but I have no objection to being
> proactive here.
Oh yeah, I'm completely fine either way too.
> But the hard part... Thought for a good name? ;-)
If we go with a separate interface, yeah, _flush would be confusing for
workqueue. Maybe _quick or _hurry? Hmm... it'd be nice to keep the suffix
consistent with RCU. What's the relationship with
synchronize_rcu_expedited()? Would using _expedited be confusing?
Thanks.
--
tejun
next prev parent reply other threads:[~2022-11-22 1:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 1:04 [PATCH rcu 0/16 Lazy call_rcu() updates for v6.2 Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 01/16] rcu: Simplify rcu_init_nohz() cpumask handling Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 02/16] rcu: Fix late wakeup when flush of bypass cblist happens Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 03/16] rcu: Fix missing nocb gp wake on rcu_barrier() Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 04/16] rcu: Make call_rcu() lazy to save power Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 05/16] rcu: Refactor code a bit in rcu_nocb_do_flush_bypass() Paul E. McKenney
2022-11-23 15:59 ` Frederic Weisbecker
2022-11-23 17:54 ` Paul E. McKenney
2022-11-24 1:00 ` Joel Fernandes
2022-11-22 1:04 ` [PATCH v2 rcu 06/16] rcu: Shrinker for lazy rcu Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 07/16] rcuscale: Add laziness and kfree tests Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 08/16] percpu-refcount: Use call_rcu_flush() for atomic switch Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 09/16] rcu/sync: Use call_rcu_flush() instead of call_rcu Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 10/16] rcu/rcuscale: Use call_rcu_flush() for async reader test Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 11/16] rcu/rcutorture: Use call_rcu_flush() where needed Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 12/16] scsi/scsi_error: Use call_rcu_flush() instead of call_rcu() Paul E. McKenney
2022-11-26 0:11 ` Bart Van Assche
2022-11-28 21:39 ` Paul E. McKenney
2022-11-26 2:42 ` Martin K. Petersen
2022-11-22 1:04 ` [PATCH v2 rcu 13/16] workqueue: Make queue_rcu_work() use call_rcu_flush() Paul E. McKenney
2022-11-22 1:09 ` Tejun Heo
2022-11-22 1:23 ` Paul E. McKenney
2022-11-22 1:37 ` Tejun Heo [this message]
2022-11-22 1:52 ` Paul E. McKenney
2022-11-22 21:30 ` Tejun Heo
2022-11-22 1:04 ` [PATCH v2 rcu 14/16] rxrpc: Use call_rcu_flush() instead of call_rcu() Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 15/16] net: Use call_rcu_flush() for dst_release() Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 16/16] net: devinet: Reduce refcount before grace period Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3wn9AK1XxEZIIFw@slm.duckdns.org \
--to=tj@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®