mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: fotg210-udc: Remove a useless assignment
Date: Tue, 22 Nov 2022 17:26:46 +0100	[thread overview]
Message-ID: <Y3z4RrPaNENoujtJ@kroah.com> (raw)
In-Reply-To: <CACRpkdY4+FtRc63GY_A2Gwr-cstMfsMvojHmQ_o2UQP0ymasig@mail.gmail.com>

On Tue, Nov 15, 2022 at 10:42:02PM +0100, Linus Walleij wrote:
> On Mon, Nov 14, 2022 at 9:38 PM Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> wrote:
> 
> > There is no need to use an intermediate array for these memory allocations,
> > so, axe it.
> >
> > While at it, turn a '== NULL' into a shorter '!' when testing memory
> > allocation failure.
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> 
> Fair enough!
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> I have sent some other cleanups to this code only
> yesterday, so they might collide and they you might have
> to rebase.

I fixed it up, no need to resend.

thanks,

greg k-h

      reply	other threads:[~2022-11-22 16:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14 20:38 Christophe JAILLET
2022-11-15 21:42 ` Linus Walleij
2022-11-22 16:26   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3z4RrPaNENoujtJ@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®