From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7353DC433FE for ; Tue, 22 Nov 2022 16:49:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234227AbiKVQtC (ORCPT ); Tue, 22 Nov 2022 11:49:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234127AbiKVQs5 (ORCPT ); Tue, 22 Nov 2022 11:48:57 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 939646D494 for ; Tue, 22 Nov 2022 08:48:56 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D20291FB; Tue, 22 Nov 2022 08:49:02 -0800 (PST) Received: from FVFF77S0Q05N.cambridge.arm.com (FVFF77S0Q05N.cambridge.arm.com [10.1.32.179]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6D5333F73D; Tue, 22 Nov 2022 08:48:55 -0800 (PST) Date: Tue, 22 Nov 2022 16:48:52 +0000 From: Mark Rutland To: Ren Zhijie Cc: catalin.marinas@arm.com, will@kernel.org, yusongping@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: armv8_deprecated: fix unused-function error Message-ID: References: <20221122032010.202956-1-renzhijie2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221122032010.202956-1-renzhijie2@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 22, 2022 at 03:20:10AM +0000, Ren Zhijie wrote: > If CONFIG_SWP_EMULATION is not set and > CONFIG_CP15_BARRIER_EMULATION is not set, > aarch64-linux-gnu complained about unused-function : > > arch/arm64/kernel/armv8_deprecated.c:67:21: error: ‘aarch32_check_condition’ defined but not used [-Werror=unused-function] > static unsigned int aarch32_check_condition(u32 opcode, u32 psr) > ^~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > To fix this error, warp the definition of > aarch32_check_condition() by defined(CONFIG_SWP_EMULATION) || > defined(CONFIG_CP15_BARRIER_EMULATION) > > Fixes: 0c5f416219da ("arm64: armv8_deprecated: move aarch32 helper earlier") This also depends on building with additional options to turn warnings into errors, no? > Signed-off-by: Ren Zhijie > --- > arch/arm64/kernel/armv8_deprecated.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c > index ed0788cf6bbb..3f29ceb6653a 100644 > --- a/arch/arm64/kernel/armv8_deprecated.c > +++ b/arch/arm64/kernel/armv8_deprecated.c > @@ -64,6 +64,7 @@ struct insn_emulation { > > #define ARM_OPCODE_CONDITION_UNCOND 0xf > > +#if defined(CONFIG_SWP_EMULATION) || defined(CONFIG_CP15_BARRIER_EMULATION) > static unsigned int aarch32_check_condition(u32 opcode, u32 psr) > { > u32 cc_bits = opcode >> 28; > @@ -76,6 +77,7 @@ static unsigned int aarch32_check_condition(u32 opcode, u32 psr) > } > return ARM_OPCODE_CONDTEST_UNCOND; > } > +#endif Could we mark this as '__maybe_unused' or 'inline' instead? I think that's preferable to the ifdeferry. Thanks, Mark. > > #ifdef CONFIG_SWP_EMULATION > /* > -- > 2.17.1 >