From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
djrscally@gmail.com, heikki.krogerus@linux.intel.com,
sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org,
rafael@kernel.org
Subject: Re: [PATCH v2] device property: fix of node refcount leak in fwnode_graph_get_next_endpoint()
Date: Tue, 22 Nov 2022 15:16:50 +0200 [thread overview]
Message-ID: <Y3zLwj/G/E3kZsJE@smile.fi.intel.com> (raw)
In-Reply-To: <75602dce-0780-e51a-c8c9-d1820ddf3e2b@huawei.com>
On Tue, Nov 22, 2022 at 09:12:41PM +0800, Yang Yingliang wrote:
> On 2022/11/22 20:54, Andy Shevchenko wrote:
> > On Tue, Nov 22, 2022 at 08:00:39PM +0800, Yang Yingliang wrote:
...
> > It seems too complicated for the simple fix.
> >
> > As I said, just drop const qualifier and add fwnode_handle_get() in the 'else'
> > branch. This will allow you to drop if (prev) at the end.
>
> fwnode is const, fwnode_handle_get doesn't accept this type.
I'm talking about parent.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-22 13:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 12:00 Yang Yingliang
2022-11-22 12:54 ` Andy Shevchenko
2022-11-22 12:56 ` Andy Shevchenko
2022-11-22 12:58 ` Andy Shevchenko
2022-11-22 13:14 ` Yang Yingliang
2022-11-22 13:12 ` Yang Yingliang
2022-11-22 13:16 ` Andy Shevchenko [this message]
2022-11-22 13:41 ` Yang Yingliang
2022-11-22 14:07 ` Andy Shevchenko
2022-11-22 14:22 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3zLwj/G/E3kZsJE@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®