From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47C38C4321E for ; Mon, 5 Dec 2022 12:08:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231664AbiLEMIF (ORCPT ); Mon, 5 Dec 2022 07:08:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231661AbiLEMHh (ORCPT ); Mon, 5 Dec 2022 07:07:37 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E5C8DF55 for ; Mon, 5 Dec 2022 04:07:31 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EAC996100F for ; Mon, 5 Dec 2022 12:07:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E08C2C433C1; Mon, 5 Dec 2022 12:07:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670242050; bh=K+Dd7xGXTDkGOUmFSn+Tmrppo1MrzYY2Lk+azYRrNIg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m1gkj5247+U4OLnyaCx2lbX33R9pdpFcyuxaNcBbQzKrA1hlMuZw7xpg76kPEO27x kUm7v+2SXEaVcuxFuOz86wLmKDzu8jfpk5jdqtYWWkq/1y7iJm+ITBsy+uOXINE5gg D/IlOVOJUaYUQqS9NqMbjywD7kVo4V0mpp0VNEChvkZSJhIffAXsFnv/ZjJ1haKzM9 xB9L/3UcEy78yD/SaFiHTyYNCWOhT+r1FIFXZsC54p7ttrL5HoYvAjVP1FUBxLIid3 K9TQjW0zvBmMidab5XPUhSr1LVM/uw0Gh5Vounv45TXpabRWy0RSWfyiqpbjOyX1cI LMBCv/rdqg6ww== Date: Mon, 5 Dec 2022 12:07:20 +0000 From: Mark Brown To: Jiaxin Yu =?utf-8?B?KOS/nuWutumRqyk=?= Cc: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "ajye_huang@compal.corp-partner.google.com" , Chunxu Li =?utf-8?B?KOadjuaYpeaXrSk=?= , Allen-KH Cheng =?utf-8?B?KOeoi+WGoOWLsyk=?= , "dri-devel@lists.freedesktop.org" , "kuninori.morimoto.gx@renesas.com" , "andrzej.hajda@intel.com" , "linux-arm-kernel@lists.infradead.org" , Project_Global_Chrome_Upstream_Group , "robert.foss@linaro.org" , "Laurent.pinchart@ideasonboard.com" , "neil.armstrong@linaro.org" , "angelogioacchino.delregno@collabora.com" , "nfraprado@collabora.com" , "alsa-devel@alsa-project.org" Subject: Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX Message-ID: References: <20221125094413.4940-1-jiaxin.yu@mediatek.com> <20221125094413.4940-2-jiaxin.yu@mediatek.com> <18c82f6f723cd97a9d6b9a7ff16c6ed62fd005d6.camel@mediatek.com> <7023a2c7b471d6888d9079563a6c01f22599201f.camel@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2Zxw/Hvoq9IhDAxu" Content-Disposition: inline In-Reply-To: <7023a2c7b471d6888d9079563a6c01f22599201f.camel@mediatek.com> X-Cookie: If it ain't broke, don't fix it. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2Zxw/Hvoq9IhDAxu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 05, 2022 at 09:34:17AM +0000, Jiaxin Yu (=E4=BF=9E=E5=AE=B6=E9= =91=AB) wrote: > 1. I have added a DAPM widget that is "SDB", when we open or close HDMI > PIN_SWITCH, the callback 'hdmi_tx_event' registered in the widget will > be triggered. Maybe you mean I shouldn't use SNDRV_PCM_TRIGGER_START > and SNDRV_PCM_TRIGGER_STOP? No, I mean that if you want to control the enable and disable of the output path you should implement a DAPM widget. > 2. If I don't use hcd.ops->trigger notifies the bridge ic driver to > switch the audio, which ops should I use? > I actually want to know hdmi-codec.c and it6505.c except > hdmi_codec_ops, is there any other way to communicate? Like I said you should use the event on the DAPM widget. This will require providing operations for the events to the drivers. --2Zxw/Hvoq9IhDAxu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmON3vcACgkQJNaLcl1U h9Cbhgf+LMvcJgTpZwsDot1swl9dxC4R5KoASnnVtW3qUnTy6RJishGkt+FKlLX8 aw/XM5uZSMX1WA040KY4LRSrz/jSPdW2esD5PxtNo7+z87LmRi/AL9539cd8zu89 jNhbtBAQDyiNp1Y5mNKjEoL6wCbFS7Zt8XMnXHxddRKZClHNgn1q5/ZbfkbNP++Y zsXuNSRUT4lzbBlfe2tRMJ1mPdz2R1Is+7sbNZIPIU4t741icrKukcCYPOuYfQeb 38OZ3gVyERI/AIfp7P0X5SLklXuTFFxAhbg617Bp254suyarICucIyvSvp7iTNxq hg3akba+kzI36lZ6YuhE4NvJC589kQ== =lrjL -----END PGP SIGNATURE----- --2Zxw/Hvoq9IhDAxu--