From: Francesco Dolcini <francesco@dolcini.it>
To: Sherry Sun <sherry.sun@nxp.com>,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
ilpo.jarvinen@linux.intel.com
Cc: lukas@wunner.de, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
Fabio Estevam <festevam@gmail.com>,
max.krummenacher@toradex.com
Subject: Re: [PATCH] Revert "serial: fsl_lpuart: Reset prior to registration"
Date: Tue, 6 Dec 2022 15:51:16 +0100 [thread overview]
Message-ID: <Y49W5DuvGcqh0PFw@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <20220929085318.5268-1-sherry.sun@nxp.com>
Hello all,
On Thu, Sep 29, 2022 at 04:53:18PM +0800, Sherry Sun wrote:
> This reverts commit 60f361722ad2ae5ee667d0b0545d40c42f754daf.
>
> commit 60f361722ad2 ("serial: fsl_lpuart: Reset prior to registration")
> causes the lpuart console cannot work any more. Since the console is
> registered in the uart_add_one_port(), the driver cannot identify the
> console port before call uart_add_one_port(), which causes all the uart
> ports including the console port will be global reset.
> So need to revert this patch to avoid breaking the lpuart console.
>
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
What's the status/plan on this?
From what I can tell the commit this patch is reverting introduced a
regression (that was backported to stable kernel), it should have a
Fixes tag and probably a cc:stable.
See also https://github.com/Freescale/linux-fslc/commit/a682d463667a418d3f7277dbbe06cd6347e76761
Francesco
next prev parent reply other threads:[~2022-12-06 15:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 8:53 Sherry Sun
2022-09-29 10:51 ` Ilpo Järvinen
2022-09-29 11:10 ` Sherry Sun
2022-09-29 11:19 ` Ilpo Järvinen
2022-09-30 8:02 ` Sherry Sun
2022-09-30 12:59 ` Ilpo Järvinen
2022-10-09 10:23 ` Sherry Sun
2022-10-10 9:09 ` Lukas Wunner
2022-10-11 8:07 ` Sherry Sun
2022-12-06 14:51 ` Francesco Dolcini [this message]
2022-12-06 15:08 ` Francesco Dolcini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y49W5DuvGcqh0PFw@francesco-nb.int.toradex.com \
--to=francesco@dolcini.it \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=max.krummenacher@toradex.com \
--cc=sherry.sun@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®