From: Richard Cochran <richardcochran@gmail.com>
To: Arun Ramadoss <arun.ramadoss@microchip.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com,
olteanv@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk,
Tristram.Ha@microchip.com, ceggers@arri.de
Subject: Re: [Patch net-next v2 06/13] net: ptp: add helper for one-step P2P clocks
Date: Tue, 6 Dec 2022 08:38:07 -0800 [thread overview]
Message-ID: <Y49v73+Hg7x3JhFS@hoboy.vegasvil.org> (raw)
In-Reply-To: <20221206091428.28285-7-arun.ramadoss@microchip.com>
On Tue, Dec 06, 2022 at 02:44:21PM +0530, Arun Ramadoss wrote:
> From: Christian Eggers <ceggers@arri.de>
>
> For P2P delay measurement, the ingress time stamp of the PDelay_Req is
> required for the correction field of the PDelay_Resp. The application
> echoes back the correction field of the PDelay_Req when sending the
> PDelay_Resp.
>
> Some hardware (like the ZHAW InES PTP time stamping IP core) subtracts
> the ingress timestamp autonomously from the correction field, so that
> the hardware only needs to add the egress timestamp on tx. Other
> hardware (like the Microchip KSZ9563) reports the ingress time stamp via
> an interrupt and requires that the software provides this time stamp via
> tail-tag on tx.
>
> In order to avoid introducing a further application interface for this,
> the driver can simply emulate the behavior of the InES device and
> subtract the ingress time stamp in software from the correction field.
>
> On egress, the correction field can either be kept as it is (and the
> time stamp field in the tail-tag is set to zero) or move the value from
> the correction field back to the tail-tag.
>
> Changing the correction field requires updating the UDP checksum (if UDP
> is used as transport).
>
> Reported-by: kernel test robot <lkp@intel.com>
How can a test robot report new code additions?
Thanks,
Richard
next prev parent reply other threads:[~2022-12-06 16:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 9:14 [Patch net-next v2 00/13] net: dsa: microchip: add PTP support for KSZ9563/KSZ8563 and LAN937x Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 01/13] net: dsa: microchip: ptp: add the posix clock support Arun Ramadoss
2022-12-06 10:37 ` Christian Eggers
2022-12-06 10:48 ` Vladimir Oltean
2022-12-07 4:26 ` Arun.Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 02/13] net: dsa: microchip: ptp: Initial hardware time stamping support Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 03/13] net: dsa: microchip: ptp: add 4 bytes in tail tag when ptp enabled Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 04/13] net: dsa: microchip: ptp: manipulating absolute time using ptp hw clock Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 05/13] net: dsa: microchip: ptp: enable interrupt for timestamping Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 06/13] net: ptp: add helper for one-step P2P clocks Arun Ramadoss
2022-12-06 16:38 ` Richard Cochran [this message]
2022-12-07 4:15 ` Arun.Ramadoss
2022-12-07 10:33 ` Vladimir Oltean
2022-12-06 9:14 ` [Patch net-next v2 07/13] net: dsa: microchip: ptp: add packet reception timestamping Arun Ramadoss
2022-12-06 12:53 ` Vladimir Oltean
2022-12-07 6:00 ` Arun.Ramadoss
2022-12-07 10:38 ` Vladimir Oltean
2022-12-06 9:14 ` [Patch net-next v2 08/13] net: dsa: microchip: ptp: add packet transmission timestamping Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 09/13] net: dsa: microchip: ptp: move pdelay_rsp correction field to tail tag Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 10/13] net: dsa: microchip: ptp: add periodic output signal Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 11/13] net: dsa: microchip: ptp: add support for perout programmable pins Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 12/13] net: dsa: microchip: ptp: lan937x: add 2 step timestamping Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 13/13] net: dsa: microchip: ptp: lan937x: Enable periodic output in LED pins Arun Ramadoss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y49v73+Hg7x3JhFS@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=ceggers@arri.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®