From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jianglei Nie <niejianglei2021@163.com>
Cc: ojeda@kernel.org, geert+renesas@glider.be,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] auxdisplay: hd44780: Fix potential memory leak in hd44780_remove()
Date: Mon, 28 Nov 2022 12:59:28 +0200 [thread overview]
Message-ID: <Y4SUkGYK5Y6Uo3Bv@smile.fi.intel.com> (raw)
In-Reply-To: <Y4SRUwKFGJfwNZ2U@smile.fi.intel.com>
On Mon, Nov 28, 2022 at 12:45:39PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 28, 2022 at 04:44:21PM +0800, Jianglei Nie wrote:
...
> Fixes: 718e05ed92ec ("auxdisplay: Introduce hd44780_common.[ch]")
>
> What you found has nothing to do with the issue. Issue has been introduced
> later on.
Side note (mostly for Miguel): That series by Lars was indeed problematic.
And I see now that he didn't get the parameter to the charlcd_alloc(). Now
we have problem that your patch solves and dangling parameter in the struct
charlcd_priv. So, I will restore charlcd_alloc() before his series (after
this patch has been applied, because of the backport needs) for a new
kernel development cycle.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-28 10:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 8:44 Jianglei Nie
2022-11-28 10:45 ` Andy Shevchenko
2022-11-28 10:59 ` Andy Shevchenko [this message]
2025-02-24 17:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4SUkGYK5Y6Uo3Bv@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=niejianglei2021@163.com \
--cc=ojeda@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®