From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25875C4167B for ; Tue, 29 Nov 2022 12:23:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233193AbiK2MXY (ORCPT ); Tue, 29 Nov 2022 07:23:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbiK2MXV (ORCPT ); Tue, 29 Nov 2022 07:23:21 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1699E303FA for ; Tue, 29 Nov 2022 04:23:21 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 700F84E6; Tue, 29 Nov 2022 13:23:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1669724598; bh=ztG42iIhYdUHImwuvJ2KShcJ26uhez7o9Otsn3LbX7c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tlGrRJncTvoHhfJ9dcOWC9D+acIqO7bNP8T61ccEw28NWEqjN7oZOj9a38DGpidkO 1Ws/Ds6+kIr78TwPqgxqMtwVfIxKm9EdjaPWn/IvnROk3mioaCHQx60lou3uxNIMJ4 SQrjB15SK4kGwiRfTH78Wd/W0y+4/66LFQpYqjg8= Date: Tue, 29 Nov 2022 14:22:59 +0200 From: Laurent Pinchart To: Maxime Ripard Cc: Emma Anholt , Maxime Ripard , Rob Herring , Daniel Vetter , Eric Anholt , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Joerg Quinten , Chris Morgan , Dave Stevenson Subject: Re: [PATCH v2 1/7] media: uapi: add MEDIA_BUS_FMT_RGB565_1X24_CPADHI Message-ID: References: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> <20221013-rpi-dpi-improvements-v2-1-7691903fb9c8@cerno.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221013-rpi-dpi-improvements-v2-1-7691903fb9c8@cerno.tech> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime and Chris, Thank you for the patch. On Thu, Oct 20, 2022 at 10:30:45AM +0200, Maxime Ripard wrote: > From: Chris Morgan > > Add the MEDIA_BUS_FMT_RGB565_1X24_CPADHI format used by the Geekworm > MZP280 panel for the Raspberry Pi. > > Signed-off-by: Chris Morgan > Signed-off-by: Maxime Ripard Reviewed-by: Laurent Pinchart > --- > .../userspace-api/media/v4l/subdev-formats.rst | 37 ++++++++++++++++++++++ > include/uapi/linux/media-bus-format.h | 3 +- > 2 files changed, 39 insertions(+), 1 deletion(-) > > diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.rst b/Documentation/userspace-api/media/v4l/subdev-formats.rst > index d21d532eee15..1e61c02aa788 100644 > --- a/Documentation/userspace-api/media/v4l/subdev-formats.rst > +++ b/Documentation/userspace-api/media/v4l/subdev-formats.rst > @@ -986,6 +986,43 @@ The following tables list existing packed RGB formats. > - g\ :sub:`2` > - g\ :sub:`1` > - g\ :sub:`0` > + * .. _MEDIA-BUS-FMT-RGB565-1X24_CPADHI: > + > + - MEDIA_BUS_FMT_RGB565_1X24_CPADHI > + - 0x1022 > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - 0 > + - 0 > + - 0 > + - r\ :sub:`4` > + - r\ :sub:`3` > + - r\ :sub:`2` > + - r\ :sub:`1` > + - r\ :sub:`0` > + - 0 > + - 0 > + - g\ :sub:`5` > + - g\ :sub:`4` > + - g\ :sub:`3` > + - g\ :sub:`2` > + - g\ :sub:`1` > + - g\ :sub:`0` > + - 0 > + - 0 > + - 0 > + - b\ :sub:`4` > + - b\ :sub:`3` > + - b\ :sub:`2` > + - b\ :sub:`1` > + - b\ :sub:`0` > * .. _MEDIA-BUS-FMT-RGB666-1X24_CPADHI: > > - MEDIA_BUS_FMT_RGB666_1X24_CPADHI > diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h > index ec3323dbb927..b0a945eb7040 100644 > --- a/include/uapi/linux/media-bus-format.h > +++ b/include/uapi/linux/media-bus-format.h > @@ -34,13 +34,14 @@ > > #define MEDIA_BUS_FMT_FIXED 0x0001 > > -/* RGB - next is 0x1022 */ > +/* RGB - next is 0x1023 */ > #define MEDIA_BUS_FMT_RGB444_1X12 0x1016 > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 > #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE 0x1003 > #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_LE 0x1004 > #define MEDIA_BUS_FMT_RGB565_1X16 0x1017 > +#define MEDIA_BUS_FMT_RGB565_1X24_CPADHI 0x1022 > #define MEDIA_BUS_FMT_BGR565_2X8_BE 0x1005 > #define MEDIA_BUS_FMT_BGR565_2X8_LE 0x1006 > #define MEDIA_BUS_FMT_RGB565_2X8_BE 0x1007 > -- Regards, Laurent Pinchart